automated duplicating imported samples modifications by robGG1997 · Pull Request #595 · ChainSafe/web3.unity

robGG1997 · 2023-09-06T08:48:16Z

this will automate the dev process of duplicating modifications to the imported package sample
uses a bash script to remove and duplicate samples folder
uses a git actions workflow duplicate_sample.yml to check for changes to imported package sample to run duplicate_package_sample.sh and commit and push any changes if they exist
This will only be automated to add a commit when a push happens to main (successful pull request)

… and a bash script duplicate_package_sample.sh

RyRy79261 · 2023-09-06T16:25:04Z

@robGG1997 We might want a shell script for Windows as well

sneakzttv · 2023-09-06T17:23:57Z

@robGG1997 We might want a shell script for Windows as well

Just use git, it gives you bash for windows https://git-scm.com/downloads

RyRy79261 · 2023-09-07T12:45:48Z

@sneakzttv I normally use WSL2 so anything git related runs out of that section, but the issue is pathing buggers out for all the .Net stuff for me, so I just run directly out of windows

sneakzttv · 2023-09-07T13:15:38Z

@sneakzttv I normally use WSL2 so anything git related runs out of that section, but the issue is pathing buggers out for all the .Net stuff for me, so I just run directly out of windows

Fair

sneakzttv · 2023-09-07T19:01:01Z

hmm... forked the branch, added a comment and made a commit. Initialized the build then reimported sample via the package manager and the comment had been reset. If this is because the branch was forked then ignore me, otherwise it was working fine on initial import. @robGG1997 just confirm when you can and i'll approve based on said outcome.

robGG1997 · 2023-09-07T19:17:52Z

hmm... forked the branch, added a comment and made a commit. Initialized the build then reimported sample via the package manager and the comment had been reset. If this is because the branch was forked then ignore me, otherwise it was working fine on initial import. @robGG1997 just confirm when you can and i'll approve based on said outcome.

Have you set up pre-commit in .git/hooks?

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * small revert to login scene load changes and lootboxes sample duplicate added to CI * Auto-duplicate Packages Samples * Goerli check modified/optimized to be easily replaced with sepolia or other chain * Auto-duplicate Packages Samples * Logo.psd file in sprites removed * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

…ually by labeling PR `ready-to-merge` and/or ready_for_review (PR out of draft) (#710) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * auto commit on PR then run tests manually on labeling with ready-to-merge * trigger checks when PR is out of draft and ready for review too * reverted auto commit actions triggers to workflow call and added a new workflow for making auto commits This is done to avoid a head ref error when trying to make two pushes simultaneously * new workflow for auto commiting * small typo fix

* Fixed debug script * Corrected directory * Re-ran scripts * Lootboxes Sample Fix [Merge Second] (#704) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * small revert to login scene load changes and lootboxes sample duplicate added to CI * Auto-duplicate Packages Samples * Goerli check modified/optimized to be easily replaced with sepolia or other chain * Auto-duplicate Packages Samples * Logo.psd file in sprites removed * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com> * CI updates [Merge Third] - auto commits on PR then trigger checks manually by labeling PR `ready-to-merge` and/or ready_for_review (PR out of draft) (#710) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * auto commit on PR then run tests manually on labeling with ready-to-merge * trigger checks when PR is out of draft and ready for review too * reverted auto commit actions triggers to workflow call and added a new workflow for making auto commits This is done to avoid a head ref error when trying to make two pushes simultaneously * new workflow for auto commiting * small typo fix * Merged main & rebuilt * Published Solution Dependencies to Package Libraries as DLLs * Update scripts/debug-publish-to-unity-package.bat * Fixed --------- Co-authored-by: robGG1997 <142783680+robGG1997@users.noreply.github.com> Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com> Co-authored-by: RyRy79261 <RyRy79261@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * Changes made + dlls ignored again in .gitignore for packages since we now use CI to generate them + Delete WC storage file if session isn't being restored + Save files closer to project when Application.isEditor for convenience * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * reverted unwanted changes back to main * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * checkpoint * added overload with different typed tokenId parameter * reverted type cast for batchOwnerOf * small optimization changes * Auto-duplicate Packages Samples * tokenId type now BigInteger * added overload implementation for 1155 * fix for loading SampleImportNftTexture scene * Auto-duplicate Packages Samples --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * setup for IOS build based WC's feedback * added custom websocket implementation * refactor and cleanup * moved web socket as plugin in packages * fixed ws destroy error * reuse connection builder after a logout * ignore generated data files in sample project * removed some unwanted changes and ignored files * removed editor folder from assets and added docs for connection builder in WalletConnectConfig.cs * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * transfer erc 1155 test now passing * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * Disposing of WC instances done properly * Published Solution Dependencies to Package Libraries as DLLs * reverted merge changes * Published Solution Dependencies to Package Libraries as DLLs * file sharing error possible fix * Published Solution Dependencies to Package Libraries as DLLs * compile error fixes * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * lint fix * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * transfer erc721 hash updated to sepolia --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added meta files and disabled publish dlls workflow

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * WebGLThreadingPatcherInstaller dialog

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * .meta generation CI * small ref update * possible fix * helpful echos added * now running action on this branch :facepalm * don't export DLL_META_FILE_TEMPLATE variable * small updates * back to echo * maybe try touch * helpful echos and changed overwrite to append * genrate UUID using uuidgen * if else cases for already existing meta files and only deleting .dll files * fixed path issue * rm dlls path fix * Published Solution Dependencies to Package Libraries as DLLs * changed publish dependencies action auto commit branch back to main * skip running publish dll * revert unwanted changes back to main --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * possible redirect fix * Published Solution Dependencies to Package Libraries as DLLs * possible fix * use redirect used in WalletConnectUnity project https://github.com/WalletConnect/WalletConnectUnity/ * reverted src/UnitySampleProject/Packages/packages-lock.json to main * Published Solution Dependencies to Package Libraries as DLLs * added wc prefix to links and removed url encoding * Published Solution Dependencies to Package Libraries as DLLs * added encode to uri * Published Solution Dependencies to Package Libraries as DLLs * revert merge changes * Published Solution Dependencies to Package Libraries as DLLs * new dlls --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * re enable Publish Dependencies CI * Published Solution Dependencies to Package Libraries as DLLs * revert to main * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * Updated analytics and package.json to 2.5.4 release. * Published Solution Dependencies to Package Libraries as DLLs * revert from main * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * working demo and build * Revert "working demo and build" This reverts commit 06cb9d9. * first MetaMask iteration * Auto-duplicate Packages Samples * added new custom dlls for Neth.MetaMask * typo and compile error fixes * Published Solution Dependencies to Package Libraries as DLLs * sign message and sign typed data implemented and working, send transaction implemented not fully working * fixed send Transaction issue * simultaneous requests supported and fixed send transaction issue * refactor and documentation * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * set exception if connection fails * added required line in index.html in WebGL template * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * made requested changes * Published Solution Dependencies to Package Libraries as DLLs * more requested changes * merged wallet connect extension methods * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * removed redundant/empty implementations of IlifeCycleParticipant * added import statement * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * added platform dependent compilation to avoid build errors * limited metamask libs to WebGL so it can build to other platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * working demo and build * Revert "working demo and build" This reverts commit 06cb9d9. * first MetaMask iteration * Auto-duplicate Packages Samples * added new custom dlls for Neth.MetaMask * typo and compile error fixes * Published Solution Dependencies to Package Libraries as DLLs * sign message and sign typed data implemented and working, send transaction implemented not fully working * fixed send Transaction issue * simultaneous requests supported and fixed send transaction issue * refactor and documentation * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * set exception if connection fails * added required line in index.html in WebGL template * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * libc Dll not found exception fixed * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * made requested changes * Published Solution Dependencies to Package Libraries as DLLs * more requested changes * merged wallet connect extension methods * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * removed redundant/empty implementations of IlifeCycleParticipant * added import statement * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * added platform dependent compilation to avoid build errors * limited metamask libs to WebGL so it can build to other platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * revert from merge * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * fixed compile error on Unity WebGL * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * changed gas nonce test hash * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * test run 1 * test run 2 * test run 3 * test run 4 * test run 5 * revert testing branch change * Published Solution Dependencies to Package Libraries as DLLs * reverted changes from merge * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * data files now save in persistent data path only and we now have menu items in tools for easy access * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * open persistent data path supports more platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * data files now save in persistent data path only and we now have menu items in tools for easy access * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * open persistent data path supports more platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * working flow * checkpoint * setup.bat now works like setup.sh and published_dependencies.txt uses new lines instead of spaces * updated branch for testing * Published Solution Dependencies to Package Libraries as DLLs * reverted testing branch change --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * fix Null Ref error on Android Builds when redirecting * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * checkpoint * pushed changes made * added documentation and removed scene indexers * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * ramp adapter added and small merge revert * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * using statemet removed * version bumped to 2.5.5 * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: rob1997 <rob1997@users.noreply.github.com>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * checkpoint * ignored samples * Make commits on push to dev and checks on PR to main and dev * test 1 * unity tests and push refactored into jobs instead of steps * removed unity tests from check and commit * reverted libraries delete * test commit message * test commit message 2 * test commit message 3 * added tests and workflow call usage * unity tests run on workflow call now * switched test branch to dev * Edited CONTRIBUTION.md to reflect flow changes * some syntax changes * small syntax fix --------- Co-authored-by: robGG1997 <robel@chainsafe.io>

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io>

* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Fixing sample script comments (#930) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix (#931) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Sneakz/typo fix (#933) Update DisableGameObjectIfServiceNotActive.cs * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>

* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Fixing sample script comments (#930) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix (#931) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Sneakz/typo fix (#933) Update DisableGameObjectIfServiceNotActive.cs * Removing Sygma from ILoginProvider * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Update ILoginProvider.cs --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> Co-authored-by: Nikola Garabandic <kantagara@gmail.com> Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>

automated duplicating imported samples modifications using pre-commit…

8856a46

… and a bash script duplicate_package_sample.sh

robGG1997 requested review from RyRy79261, juans-chainsafe, kalambet, oleksandrchainsafe and sneakzttv September 6, 2023 08:48

robGG1997 self-assigned this Sep 6, 2023

robGG1997 changed the title ~~automated duplicating imported samples modifications using pre-commit…~~ automated duplicating imported samples modifications Sep 6, 2023

robGG1997 linked an issue Sep 6, 2023 that may be closed by this pull request

Automate duplicating/copying modifications to importable package sample #593

Closed

sneakzttv previously approved these changes Sep 6, 2023

View reviewed changes

robGG1997 dismissed sneakzttv’s stale review via ef7eb41 September 6, 2023 19:50

robGG1997 force-pushed the rob/automate-sample-modifications-593 branch 3 times, most recently from c178b05 to 8856a46 Compare September 6, 2023 20:04

robGG1997 added 7 commits September 6, 2023 23:56

Pre Commit config file added

94a01e3

added bash execution in pre commit config file

0ba7b7d

entry path changed

961296d

entry changed

c4b5436

entry path changed

8cef66b

added always run to pre-commit

be01c5a

changed type

f8aa616

robGG1997 assigned kalambet Sep 8, 2023

robGG1997 and others added 2 commits September 10, 2023 01:09

removed pre-commit config yaml brought back GitHub workflow solution

306bdf2

Merge branch 'main' into rob/automate-sample-modifications-593

f2d7707

kantagara pushed a commit that referenced this pull request Nov 21, 2023

Release Fix (#748)

792f35d

* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added meta files and disabled publish dlls workflow

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

automated duplicating imported samples modifications#595

automated duplicating imported samples modifications#595
robGG1997 merged 14 commits intomainfrom
rob/automate-sample-modifications-593

robGG1997 commented Sep 6, 2023 •

edited

Loading

Uh oh!

RyRy79261 commented Sep 6, 2023

Uh oh!

sneakzttv commented Sep 6, 2023

Uh oh!

RyRy79261 commented Sep 7, 2023

Uh oh!

sneakzttv commented Sep 7, 2023

Uh oh!

sneakzttv commented Sep 7, 2023 •

edited

Loading

Uh oh!

robGG1997 commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

robGG1997 commented Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RyRy79261 commented Sep 6, 2023

Uh oh!

sneakzttv commented Sep 6, 2023

Uh oh!

RyRy79261 commented Sep 7, 2023

Uh oh!

sneakzttv commented Sep 7, 2023

Uh oh!

sneakzttv commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robGG1997 commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

robGG1997 commented Sep 6, 2023 •

edited

Loading

sneakzttv commented Sep 7, 2023 •

edited

Loading