Skip to content

Wallet Connect QR code error fix#711

Merged
robGG1997 merged 28 commits intomainfrom
rob/wc-qr-error-fix-697
Nov 8, 2023
Merged

Wallet Connect QR code error fix#711
robGG1997 merged 28 commits intomainfrom
rob/wc-qr-error-fix-697

Conversation

@robGG1997
Copy link
Copy Markdown
Contributor

closes #697

+ dlls ignored again in .gitignore for packages since we now use CI to generate them
+ Delete WC storage file if session isn't being restored
+ Save files closer to project when Application.isEditor for convenience
@robGG1997 robGG1997 added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Nov 7, 2023
Copy link
Copy Markdown
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallect connect QR looks good!

@robGG1997 robGG1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Nov 8, 2023
@robGG1997 robGG1997 force-pushed the rob/wc-qr-error-fix-697 branch from 6a985f8 to 0c5ff79 Compare November 8, 2023 06:13
@robGG1997 robGG1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Nov 8, 2023
@robGG1997 robGG1997 merged commit e5f6783 into main Nov 8, 2023
@robGG1997 robGG1997 deleted the rob/wc-qr-error-fix-697 branch November 8, 2023 06:43
rob1997 pushed a commit that referenced this pull request Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* Changes made
+ dlls ignored again in .gitignore for packages since we now use CI to generate them
+ Delete WC storage file if session isn't being restored
+ Save files closer to project when Application.isEditor for convenience

* Auto-duplicate Packages Samples

* Published Solution Dependencies to Package Libraries as DLLs

* reverted unwanted changes back to main

* Published Solution Dependencies to Package Libraries as DLLs

---------

Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* Changes made
+ dlls ignored again in .gitignore for packages since we now use CI to generate them
+ Delete WC storage file if session isn't being restored
+ Save files closer to project when Application.isEditor for convenience

* Auto-duplicate Packages Samples

* Published Solution Dependencies to Package Libraries as DLLs

* reverted unwanted changes back to main

* Published Solution Dependencies to Package Libraries as DLLs

---------

Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to Merge PR - this'll trigger required checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wallet connect QR code error

5 participants