Conversation
This reverts commit a555894.
96179ed to
5ece09b
Compare
64eedf8 to
18d7bc3
Compare
Packages/io.chainsafe.web3-unity/Runtime/Scripts/EVM/Token/Erc721.cs
Outdated
Show resolved
Hide resolved
|
So with ERC1155, theres a concept of This allows you to see how many of a token, by its ID, an account has. If you have set up the token by that ID to be a singular, unique, NFT. Then it would return a balance of 1. If it is an NFT that you've issued a few of, say a badge for attending an event, multiple accounts could have a balance of 1. If its gold in a game, then the balance would return more than 1 in some instances: |
Understood, so I should refactor Balance function instead? |
|
@robGG1997 Yeah I rate just adding the non batch variant for 1155 if its missing is fine. I still need to actually review the code though. |
51f8b89 to
b520786
Compare
Updated |
a2327af to
4da4916
Compare
juans-chainsafe
left a comment
There was a problem hiding this comment.
Samples working! tested with wallet connect and web3auth.
Also fixed the issue with ImportNftTexture scene ✅
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * checkpoint * added overload with different typed tokenId parameter * reverted type cast for batchOwnerOf * small optimization changes * Auto-duplicate Packages Samples * tokenId type now BigInteger * added overload implementation for 1155 * fix for loading SampleImportNftTexture scene * Auto-duplicate Packages Samples --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * checkpoint * added overload with different typed tokenId parameter * reverted type cast for batchOwnerOf * small optimization changes * Auto-duplicate Packages Samples * tokenId type now BigInteger * added overload implementation for 1155 * fix for loading SampleImportNftTexture scene * Auto-duplicate Packages Samples --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
closes #701
There is no
ownerOffunction forERC1155because a token is not necessarily unique, it can have multiple owners. So I didn't implement it.BatchOwnerOfalready works with both types fortokenIdso no need for a refactor there.