Skip to content

Dispose of Wallet Connect instances properly#737

Merged
kantagara merged 47 commits intomainfrom
rob/dispose-wc-734
Nov 17, 2023
Merged

Dispose of Wallet Connect instances properly#737
kantagara merged 47 commits intomainfrom
rob/dispose-wc-734

Conversation

@robGG1997
Copy link
Copy Markdown
Contributor

closes #734

@robGG1997 robGG1997 self-assigned this Nov 16, 2023
@robGG1997 robGG1997 reopened this Nov 17, 2023
@robGG1997 robGG1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Nov 17, 2023
@robGG1997 robGG1997 removed the ready-to-merge Ready to Merge PR - this'll trigger required checks label Nov 17, 2023
@robGG1997 robGG1997 added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Nov 17, 2023
@robGG1997 robGG1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Nov 17, 2023
@robGG1997 robGG1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Nov 17, 2023
@robGG1997 robGG1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Nov 17, 2023
@kantagara kantagara merged commit 5fed0b2 into main Nov 17, 2023
@kantagara kantagara deleted the rob/dispose-wc-734 branch November 17, 2023 14:09
rob1997 pushed a commit that referenced this pull request Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* Disposing of WC instances done properly

* Published Solution Dependencies to Package Libraries as DLLs

* reverted merge changes

* Published Solution Dependencies to Package Libraries as DLLs

* file sharing error possible fix

* Published Solution Dependencies to Package Libraries as DLLs

* compile error fixes

* Auto-duplicate Packages Samples

* Published Solution Dependencies to Package Libraries as DLLs

* lint fix

* Published Solution Dependencies to Package Libraries as DLLs

* Published Solution Dependencies to Package Libraries as DLLs

* transfer erc721 hash updated to sepolia

---------

Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* Disposing of WC instances done properly

* Published Solution Dependencies to Package Libraries as DLLs

* reverted merge changes

* Published Solution Dependencies to Package Libraries as DLLs

* file sharing error possible fix

* Published Solution Dependencies to Package Libraries as DLLs

* compile error fixes

* Auto-duplicate Packages Samples

* Published Solution Dependencies to Package Libraries as DLLs

* lint fix

* Published Solution Dependencies to Package Libraries as DLLs

* Published Solution Dependencies to Package Libraries as DLLs

* transfer erc721 hash updated to sepolia

---------

Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to Merge PR - this'll trigger required checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dispose of Wallet Connect instances properly

5 participants