Vortex Vectors#4954
Closed
gatesn wants to merge 3 commits into
Closed
Conversation
connortsui20
force-pushed
the
ngates/vector
branch
3 times, most recently
from
c9f50a0 to
74ffee3
Compare
connortsui20
force-pushed
the
ngates/vector
branch
2 times, most recently
from
060a04e to
bacb67b
Compare
Signed-off-by: Nicholas Gates <nick@nickgates.com> Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ngates/vector
branch
from
bacb67b to
4480153
Compare
Contributor
|
Since I need nick to review this I'll open a new PR. |
gatesn
added a commit
that referenced
this pull request
Oct 21, 2025
Tracking Issue: #4492 Continuation of #4954 This is mostly boilerplate code with a bit more documentation than normal. There are still a few bugs in the implementation (documented by TODOs), but I would like this PR to just focus on the structure of the crate rather than the logic. Also add logic in other crates that was missing before. --- The general structure of the crate is as such: ``` vortex-vector ├── Cargo.toml └── src ├── <type> │ ├── mod.rs │ ├── vector.rs │ └── vector_mut.rs ├── lib.rs ├── macros.rs ├── ops.rs ├── private.rs ├── vector.rs └── vector_mut.rs ``` The exceptions to this structure will be `primitive`, which needs a generic type as well (so there will be extra files), a `varbin` module that holds both `binary` and `string` modules, and probably the 2 list types might share a lot of code (we'll see once I get there). Again, a lot of the logic here is not super clean and some of it is wrong, but I'd like to get this merged first before I fix those. --------- Signed-off-by: Nicholas Gates <nick@nickgates.com> Signed-off-by: Connor Tsui <connor.tsui20@gmail.com> Co-authored-by: Nicholas Gates <nick@nickgates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vectors are the first part of the move to making Vortex arrays logical plans. They will eventually largely subsume the physical functionality of the canonical arrays (leaving behind logical functionality), as well as array builders.
They follow a similar pattern to Tokio Bytes and vortex-buffer with a Vector and VectorMut that can be converted between each other with zero-copy.