Use BitBuffer instead of BooleanBuffer#4940
Merged
Merged
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
0ax1
reviewed
Oct 14, 2025
Contributor
0ax1
left a comment
0ax1
left a comment
There was a problem hiding this comment.
Can we add a small PR description on why we're doing this change, and what the properties are of BitBuffer compared BooleanBuffer?
What's our take on the Codspeed results here?
Contributor
Author
|
This has been on the backburner since February. I will make some notes. We have separately merged just the core logic but merging this is blocked on fixing codspeed results. |
Contributor
|
FWIW, the long driving motivation for this was to have BitBufferMut present a nice interface for allocating, creating, and mutating boolean buffers. BitBuffer vs BooleanBuffer is essentially no difference. |
gatesn
reviewed
Oct 20, 2025
| lookup: HashMap::with_hasher(FxBuildHasher), | ||
| values: BufferMut::<T>::empty(), | ||
| values_nulls: NullBufferBuilder::new(0), | ||
| values_nulls: BitBufferMut::empty(), |
Contributor
There was a problem hiding this comment.
TODO: use MaskMut from #4954 will have the same lazy allocation logic
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Deploying vortex-bench with
|
| Latest commit: |
59a95d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62c7e6ff.vortex-93b.pages.dev |
| Branch Preview URL: | https://rk-use-bit-buffer.vortex-93b.pages.dev |
gatesn
added
changelog/feature
github-actions
Bot
removed
the
action/benchmark
Contributor
Benchmarks: Random AccessSummary
|
This comment has been minimized.
This comment has been minimized.
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: GitHub Archive (NVMe)Summary
Detailed Results Table
|
Contributor
Benchmarks: GitHub Archive (S3)Summary
Detailed Results Table
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
github-actions
Bot
removed
the
action/benchmark-sql
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace usages of BooleanBuffer with our own BitBuffer. This lets us have our own backing Buffer for BitBuffer and implement additional optimisations for use in vortex.
previously #2456
This pr requires resolving outstanding performance issues before merging