Feature: Add vortex-vector#5010
Merged
Merged
Conversation
gatesn
reviewed
Oct 20, 2025
|
|
||
| // Otherwise, we need to copy bits into a new buffer | ||
| let mut new_buffer = BitBufferMut::with_capacity(new_len); | ||
| for i in 0..new_len { |
Contributor
There was a problem hiding this comment.
Should we slice and build the other one from iter?
Contributor
Author
There was a problem hiding this comment.
I'm not sure that would be cleaner? To be honest I didn't actually look through any of this code
Contributor
There was a problem hiding this comment.
It's not about cleaner, the performance of this won't be great
a6cf8e6 to
ee72ec4
Compare
gatesn
reviewed
Oct 20, 2025
gatesn
requested changes
Oct 20, 2025
6dae675 to
6d5f960
Compare
Signed-off-by: Nicholas Gates <nick@nickgates.com> Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Also addresses comments. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
83060da to
9d1415c
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
b1a00d1 to
912cb78
Compare
gatesn
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #5028
Roadmap: #4492
Continuation of #4954
This is mostly boilerplate code with a bit more documentation than normal.
There are still a few bugs in the implementation (documented by TODOs), but I would like this PR to just focus on the structure of the crate rather than the logic.
Also add logic in other crates that was missing before.
The general structure of the crate is as such:
The exceptions to this structure will be
primitive, which needs a generic type as well (so there will be extra files), avarbinmodule that holds bothbinaryandstringmodules, and probably the 2 list types might share a lot of code (we'll see once I get there).Again, a lot of the logic here is not super clean and some of it is wrong, but I'd like to get this merged first before I fix those.