Skip to content

OneColumnMode use setColumn(1)#1120

Merged
adumesny merged 1 commit intogridstack:developfrom
adumesny:develop
Feb 2, 2020
Merged

OneColumnMode use setColumn(1)#1120
adumesny merged 1 commit intogridstack:developfrom
adumesny:develop

Conversation

@adumesny
Copy link
Copy Markdown
Member

@adumesny adumesny commented Feb 2, 2020 •
edited
Loading

Description

Checklist

  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

OneColumnMode use setColumn(1)
128e608 
* one column mode (<768px by default) now simply calls `setColumn(1)` and remembers prev columns (so we can restore).
* This gives
us full resize/re-order of items capabilities rathern than a locked CSS only layout (see prev rev changes).

* continuation of #1098, will affect #966 as well

* NEXT: fix responsive.html which has been broken for a while.
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 2, 2020

Coverage Status

Coverage increased (+1.0%) to 67.261% when pulling 128e608 on adumesny:develop into 05d9329 on gridstack:develop.

@adumesny adumesny merged commit 621c1ce into gridstack:develop Feb 2, 2020
This was referenced Feb 2, 2020
Closed
Merged
Merged
Merged
adumesny pushed a commit that referenced this pull request Feb 4, 2020
1 column edit propagation fixes (#1127)
2876398 
* more fix #37 and part2 of #1120
* editing in 1 column (or few columns) does a better job updating higher layout
* track before and after and move items accordingly. Tracking item swap would be even better still
* column.html demo has been updated to support item delete.
* karma test updated
@adumesny adumesny mentioned this pull request Feb 5, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adumesny @coveralls