new setColumn() heuristics#1098
Merged
adumesny merged 2 commits intogridstack:developfrom Dec 19, 2019
adumesny:develop
Merged
Conversation
* complete re-write of the `setColumn()` code that moves/sizes widgets. we now do a reasonable job positioning widgets (especially 1 column), and we remember positions for each column layout to going from 12 -> 1 -> 12 will bring it exactly back for example! * new column.html test case (now that it works) to be published. * fixed bunch of bugs I found with overlapping widgets (going to 2 or 1 column) * fixed bug where default (empty) option when adding a widget would render it at (0,0) overlapping any existing widgets. added `_readAttr()/_writeAttr()` to help there. * unit test greatly updated with exact location expected of widgets (not that I agree with location) better fix than #809 fixing responsive.html will come next...
This was referenced Dec 19, 2019
Closed
This was referenced Feb 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
setColumn()code that moves/sizes widgets.we now do a reasonable job positioning widgets (especially 1 column), and
we remember positions for each column layout to going from 12 -> 1 -> 12
will bring it exactly back for example!
overlapping any existing widgets. added
readAttr()/_writeAttr()to help there.better fix than #809
fixing responsive.html will come next...
Checklist
yarn test)