Skip to content

removed oneColumnModeClass and associated code#1134

Merged
adumesny merged 1 commit intogridstack:developfrom
adumesny:develop
Feb 5, 2020
Merged

removed oneColumnModeClass and associated code#1134
adumesny merged 1 commit intogridstack:developfrom
adumesny:develop

Conversation

@adumesny
Copy link
Copy Markdown
Member

@adumesny adumesny commented Feb 5, 2020

Description

  • If you depended on this, use class .grid-stack-1 instead of .grid-stack-one-column-mode since it is 1 column layout anyway
  • updated jasmin test
  • should have been done in OneColumnMode use setColumn(1) #1120

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* If you depended on this, use class `.grid-stack-1` instead of `.grid-stack-one-column-mode` since it is 1 column layout anyway
* updated jasmin test
* should have been done in #1120
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 67.841% when pulling 85bc82e on adumesny:develop into 9e9443b on gridstack:develop.

@adumesny adumesny merged commit f46fbfc into gridstack:develop Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants