Fix for changing grid width#809
Closed
nulen wants to merge 1 commit intogridstack:developfrom
nulen:patch-1
Closed
Fix for changing grid width#809nulen wants to merge 1 commit intogridstack:developfrom nulen:patch-1
nulen wants to merge 1 commit intogridstack:developfrom
nulen:patch-1
Conversation
Updated setGridWidth method to update nodes width only after grid width is changed. Updated _updateNodeWidths method to prevent changing list during looping throgh it.
Member
|
@nulen Could you provide an example of this issue? |
Member
|
thank you for the suggestion - got me intrigued in fixing it right (1 column which is trivial always bugged me being wrong). fixed by #1098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes problem with cell positioning when grid width is changing. Now fields are positioned as intended (or I hope so).
Description
Updated setGridWidth method to update nodes widths only after grid width is changed.
Updated _updateNodeWidths method to prevent changing list during looping throgh it.