Skip to content

ci: fix download-artifact deprecation, upgrade eslint-annotate-action#238

Merged
billyvg merged 3 commits intosentry-v2from
ci-fix-upload-artifact-eskint
Jan 24, 2025
Merged

ci: fix download-artifact deprecation, upgrade eslint-annotate-action#238
billyvg merged 3 commits intosentry-v2from
ci-fix-upload-artifact-eskint

Conversation

@billyvg
Copy link
Copy Markdown
Member

@billyvg billyvg commented Jan 23, 2025

I think this needs to be in main branch for it to work

@billyvg billyvg marked this pull request as ready for review January 24, 2025 17:17
@billyvg billyvg requested a review from a team January 24, 2025 17:18
@billyvg billyvg changed the title ci: fix upload-artifact deprecation, upgrade eslint-annotate-action ci: fix download-artifact deprecation, upgrade eslint-annotate-action Jan 24, 2025
@billyvg billyvg merged commit a603d3b into sentry-v2 Jan 24, 2025
@billyvg billyvg deleted the ci-fix-upload-artifact-eskint branch January 24, 2025 17:54
chargome added a commit that referenced this pull request Apr 16, 2026
## Summary
- Bumps `markdownlint-cli` from `^0.31.1` to `^0.48.0`
- Also bumps `markdownlint` lib from `^0.25.1` to `^0.40.0` to match
- Replaces `glob` with `tinyglobby` (no more vulnerable glob dep)
- Uses `minimatch@10.2.5` (patched, replaces vulnerable 10.0.3)

## Breaking changes in markdownlint-cli 0.31 -> 0.48
- **Node.js >=20 required** (was >=12) — we use Node 20, not affected
- **`glob` replaced by `tinyglobby`** — internal dep swap, CLI interface
unchanged, not affected
- **`markdownlint` lib 0.25 -> 0.40** — internal engine upgrade,
switched to `markdown-it` parser. Some rules renamed/added. We only run
`markdownlint docs` with default config, existing warnings are
pre-existing, not affected
- **New/updated lint rules** — some rules added or tightened across
versions. Output now labels findings as "error" instead of bare rule
names. Cosmetic only, not affected
- **Config format additions** (TOML support added) — our config is
unchanged, not affected

## Dependabot alerts resolved
- Resolves glob command injection (high) — `glob` removed entirely,
replaced by `tinyglobby`
- Resolves minimatch ReDoS alerts via `minimatch@10.2.5`:
[#213](https://github.com/getsentry/rrweb/security/dependabot/213),
[#212](https://github.com/getsentry/rrweb/security/dependabot/212),
[#208](https://github.com/getsentry/rrweb/security/dependabot/208),
[#201](https://github.com/getsentry/rrweb/security/dependabot/201)
- Partially resolves brace-expansion alerts:
[#238](https://github.com/getsentry/rrweb/security/dependabot/238),
[#134](https://github.com/getsentry/rrweb/security/dependabot/134)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants