Skip to content

test(rrweb): Re-enable skipped test#229

Merged
billyvg merged 1 commit intosentry-v2from
fix-rrweb-reenable-cross-origin-test
Dec 18, 2024
Merged

test(rrweb): Re-enable skipped test#229
billyvg merged 1 commit intosentry-v2from
fix-rrweb-reenable-cross-origin-test

Conversation

@billyvg
Copy link
Copy Markdown
Member

@billyvg billyvg commented Dec 13, 2024

Re-enables test that was skipped in #172;

Re-enables test that was skipped in #172;
@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented Dec 13, 2024

Closes #172

@billyvg billyvg marked this pull request as ready for review December 13, 2024 18:22
@billyvg billyvg requested review from a team and removed request for a team December 13, 2024 18:22
Copy link
Copy Markdown

@c298lee c298lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 is it no longer flakey anymore?

@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented Dec 13, 2024

I re-ran the test 3 times so far -- will run it a few more times

edit ran 10+ times

@billyvg billyvg merged commit dd1f591 into sentry-v2 Dec 18, 2024
@billyvg billyvg deleted the fix-rrweb-reenable-cross-origin-test branch December 18, 2024 16:23
billyvg added a commit that referenced this pull request Jan 10, 2025
Re-enables test that was skipped in
#172;
billyvg added a commit that referenced this pull request Jan 14, 2025
Re-enables test that was skipped in
#172;
billyvg added a commit that referenced this pull request Jan 14, 2025
Re-enables test that was skipped in
#172;
billyvg added a commit that referenced this pull request Jan 23, 2025
Re-enables test that was skipped in
#172;
chargome added a commit that referenced this pull request Apr 24, 2026
## Summary
Updates stale yarn.lock resolutions to patched versions within their
existing semver ranges, plus fixes a build breakage in rrweb-worker.

**Lockfile refreshes** (no package.json changes):
- **basic-ftp** 5.0.5 -> 5.3.0 (via puppeteer -> proxy-agent -> get-uri)
- **node-forge** 1.3.1 -> 1.4.0 (via vite-plugin-web-extension ->
web-ext-run -> @devicefarmer/adbkit)
- **picomatch** 2.3.1 -> 2.3.2 (via chokidar, micromatch,
@rollup/pluginutils)
- **picomatch** 4.0.2 -> 4.0.4 (via @rollup/pluginutils)
- **flatted** 3.3.2 -> 3.4.2 (via eslint -> flat-cache)

**rrweb-worker build fix**: Replaces `rollup-plugin-typescript2` with
`@rollup/plugin-typescript` — the old plugin can't parse `import type`
syntax with the newer rollup version pulled in by the
`@rollup/plugin-terser` v1 bump.

## Breaking changes
- Lockfile refreshes: none — all within existing semver ranges
- `rollup-plugin-typescript2` -> `@rollup/plugin-typescript`: drop-in
replacement, same rollup plugin API. `@rollup/plugin-typescript` is the
officially maintained plugin. Config options (`tsconfig`, `sourceMap`,
`inlineSourceMap`, `inlineSources`) are compatible. Build verified
passing.

## Dependabot alerts resolved
- [Alert
#249](https://github.com/getsentry/rrweb/security/dependabot/249) (high)
— basic-ftp CRLF injection
- [Alert
#202](https://github.com/getsentry/rrweb/security/dependabot/202)
(critical) — basic-ftp path traversal
- [Alert
#237](https://github.com/getsentry/rrweb/security/dependabot/237) (high)
— node-forge basicConstraints bypass
- [Alert
#236](https://github.com/getsentry/rrweb/security/dependabot/236) (high)
— node-forge Ed25519 signature forgery
- [Alert
#235](https://github.com/getsentry/rrweb/security/dependabot/235) (high)
— node-forge RSA-PKCS signature forgery
- [Alert
#234](https://github.com/getsentry/rrweb/security/dependabot/234) (high)
— node-forge DoS via BigInteger.modInverse
- [Alert
#164](https://github.com/getsentry/rrweb/security/dependabot/164) (high)
— node-forge ASN.1 unbounded recursion
- [Alert
#163](https://github.com/getsentry/rrweb/security/dependabot/163)
(medium) — node-forge ASN.1 OID integer truncation
- [Alert
#162](https://github.com/getsentry/rrweb/security/dependabot/162) (high)
— node-forge ASN.1 desynchronization
- [Alert
#232](https://github.com/getsentry/rrweb/security/dependabot/232)
(medium) — picomatch POSIX class method injection
- [Alert
#230](https://github.com/getsentry/rrweb/security/dependabot/230)
(medium) — picomatch POSIX class method injection (4.x)
- [Alert
#229](https://github.com/getsentry/rrweb/security/dependabot/229) (high)
— picomatch ReDoS via extglob quantifiers
- [Alert
#227](https://github.com/getsentry/rrweb/security/dependabot/227) (high)
— flatted prototype pollution via parse

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants