Conversation
…ontentDocument` Do not attempt to access `contentDocument` of iframe if element is blocked, otherwise it will trigger a browser warning. e.g. `Blocked a frame with origin "<foo>" from accessing a frame with origin "<bar>". Protocols, domains, and ports must match.`
mydea
approved these changes
Jun 14, 2024
Member
mydea
left a comment
mydea
left a comment
There was a problem hiding this comment.
ahh very nice catch, that makes sense!
chargome
added a commit
that referenced
this pull request
Apr 16, 2026
## Summary - Bumps `markdownlint-cli` from `^0.31.1` to `^0.48.0` - Also bumps `markdownlint` lib from `^0.25.1` to `^0.40.0` to match - Replaces `glob` with `tinyglobby` (no more vulnerable glob dep) - Uses `minimatch@10.2.5` (patched, replaces vulnerable 10.0.3) ## Breaking changes in markdownlint-cli 0.31 -> 0.48 - **Node.js >=20 required** (was >=12) — we use Node 20, not affected - **`glob` replaced by `tinyglobby`** — internal dep swap, CLI interface unchanged, not affected - **`markdownlint` lib 0.25 -> 0.40** — internal engine upgrade, switched to `markdown-it` parser. Some rules renamed/added. We only run `markdownlint docs` with default config, existing warnings are pre-existing, not affected - **New/updated lint rules** — some rules added or tightened across versions. Output now labels findings as "error" instead of bare rule names. Cosmetic only, not affected - **Config format additions** (TOML support added) — our config is unchanged, not affected ## Dependabot alerts resolved - Resolves glob command injection (high) — `glob` removed entirely, replaced by `tinyglobby` - Resolves minimatch ReDoS alerts via `minimatch@10.2.5`: [#213](https://github.com/getsentry/rrweb/security/dependabot/213), [#212](https://github.com/getsentry/rrweb/security/dependabot/212), [#208](https://github.com/getsentry/rrweb/security/dependabot/208), [#201](https://github.com/getsentry/rrweb/security/dependabot/201) - Partially resolves brace-expansion alerts: [#238](https://github.com/getsentry/rrweb/security/dependabot/238), [#134](https://github.com/getsentry/rrweb/security/dependabot/134) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not attempt to access
contentDocumentof iframe if element is blocked, otherwise it will trigger a browser warning. e.g.Blocked a frame with origin "<foo>" from accessing a frame with origin "<bar>". Protocols, domains, and ports must match.Fixes getsentry/sentry-javascript#6560