Move use_self to nursery#4863
Merged
Merged
Conversation
Closes rust-lang#4859 We have a lot of false positives in this lint, so I think it makes sense to move this to the nursery until they are resolved. changelog: Move `use_self` lint to nursery, due to many false positives
phansch
added
S-waiting-on-review
Member
|
|
Contributor
Author
|
Huh, indeed. Not at my Clippy machine right now but I will check later today. Maybe I just forgot to commit that file. |
flip1995
removed
the
S-waiting-on-review
Member
|
@bors r+ |
Contributor
|
📌 Commit fd7eca2 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 29, 2019
Move use_self to nursery Closes #4859 We have a lot of false positives in this lint, so I think it makes sense to move this to the nursery until they are resolved. changelog: Move `use_self` lint to nursery, due to many false positives
Contributor
Contributor
|
💔 Test failed - checks-travis |
Contributor
Author
|
It looks like something's wrong with the If there's no |
Contributor
Author
|
@bors retry - maybe it was a temporary issue |
Contributor
bors
added a commit
that referenced
this pull request
Nov 29, 2019
Move use_self to nursery Closes #4859 We have a lot of false positives in this lint, so I think it makes sense to move this to the nursery until they are resolved. changelog: Move `use_self` lint to nursery, due to many false positives
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4859
We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.
changelog: Move
use_selflint to nursery, due to many false positives