Use the Self type wherever possible#208
Merged
Merged
Conversation
lhecker
approved these changes
May 22, 2025
lhecker
left a comment
lhecker
left a comment
Member
There was a problem hiding this comment.
This is fantastic! Thanks for doing this!
Do you mind running cargo clippy --fix -- -Wclippy::use_self again? Since you opened the PR, 1 more spot snuck in which could use Self instead.
Contributor
Author
|
Can you merge it and I'll do the other thing in a separate PR? |
lhecker
approved these changes
May 22, 2025
Member
|
Thanks! |
Contributor
Author
|
Also consider adding a clippy.toml file. I was never quite able to figure out how to get it to work with |
Member
|
We should probably hold off on that because of this, I guess? rust-lang/rust-clippy#4863 |
diabloproject
pushed a commit
to diabloproject/edit
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.