Skip to content

SQLiteData linux fixes #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thinkpractice wants to merge 3 commits into
base: main
Choose a base branch
from
Open

SQLiteData linux fixes #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
362d863
Bump GRDB minimum version to 7.10.0 as this is the version containing…
May 5, 2026
18c7f8f
Update package cache
May 5, 2026
222d03a
Ignore some tests and test extensions for now that are related to the…
May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/apple/swift-collections", from: "1.0.0"),
.package(url: "https://github.com/groue/GRDB.swift", from: "7.6.0"),
.package(url: "https://github.com/groue/GRDB.swift", from: "7.10.0"),
Copy link
Copy Markdown
Member

@mbrandonw mbrandonw May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to keep this relaxed to just 7.6 and then anyone that wants linux support for GRDB can explicitly depend on 7.10+?

.package(url: "https://github.com/pointfreeco/swift-concurrency-extras", from: "1.0.0"),
.package(url: "https://github.com/pointfreeco/swift-custom-dump", from: "1.3.3"),
.package(url: "https://github.com/pointfreeco/swift-dependencies", from: "1.9.0"),
Expand Down
46 changes: 24 additions & 22 deletions Tests/SQLiteDataTests/CloudKitTests/UnattachedSyncEngineTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,27 @@
import CloudKit
import CustomDump
import InlineSnapshotTesting
import SQLiteData
import SnapshotTestingCustomDump
import Testing
#if canImport(CloudKit)
import CloudKit
import CustomDump
import InlineSnapshotTesting
import SQLiteData
import SnapshotTestingCustomDump
import Testing

extension BaseCloudKitTests {
@MainActor
final class UnattachedSyncEngineTests: @unchecked Sendable {
@available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
@Test func start() async throws {
let database = try DatabasePool(path: "\(NSTemporaryDirectory())\(UUID())")
_ = try await SyncEngine(
container: MockCloudContainer(
containerIdentifier: "iCloud.co.pointfree.Testing",
privateCloudDatabase: MockCloudDatabase(databaseScope: .private),
sharedCloudDatabase: MockCloudDatabase(databaseScope: .shared)
),
userDatabase: UserDatabase(database: database),
tables: []
)
extension BaseCloudKitTests {
@MainActor
final class UnattachedSyncEngineTests: @unchecked Sendable {
@available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
@Test func start() async throws {
let database = try DatabasePool(path: "\(NSTemporaryDirectory())\(UUID())")
_ = try await SyncEngine(
container: MockCloudContainer(
containerIdentifier: "iCloud.co.pointfree.Testing",
privateCloudDatabase: MockCloudDatabase(databaseScope: .private),
sharedCloudDatabase: MockCloudDatabase(databaseScope: .shared)
),
userDatabase: UserDatabase(database: database),
tables: []
)
}
}
}
}
#endif
Loading