SQLiteData linux fixes#459
Open
thinkpractice wants to merge 3 commits intopointfreeco:mainfrom
Open
Conversation
added 3 commits
May 5, 2026 16:50
… the fixes to make GRDB build again on Linux. Also wrap the CloudKit specific tests in a #if canImport(CloudKit) to ignore these tests on Linux
… SyncEngine. Ignore them also by adding an #if canImport(CloudKit) block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLiteData Package fixes
GRDBto 7.10.0 inPackage.swiftthat contains the fixes we made to makeGRDBbuild on Linux again. No further changes were needed. By using thisGRDBversionSQLiteDatabuilds under LinuxChanges to Unit Tests
After the above changes, the unit tests still fail to build. I changed the following to make them build:
#if canImport(CloudKit)block asCloudKitis not available on Linux:UnattachedSyncEngineTests.swiftSyncEngineTestsCloudKitTestHelpers.swiftSchema.swiftthat usesCloudKit/SyncEngineUserDatabaseTestsPrimaryKeyMigrationTests, but not completely sure this was the right way to go. The tests fail to build becauseSQlite3is not found on Linux. When wrapped in acanImportblock several other constructs are not found on Linux. Either they are available in theSQLite3package and we could find an equivalent on Linux to fix these tests. However, if they are also related toSyncEnginethey should be ignored on Linux. I can't judge at this moment if this was the case.After these changes all tests that are not ignored by these changes pass. I want to also look into bringing the CI back for Linux. @stephencelis already send me some info on that. Let me know if these changes are acceptable and whether I can improve some tests to make them work on Linux as well!