investigate: isolated @mui/material 9.0.1 bump (do not merge)#503
Merged
Conversation
Isolates the suspected breakage from the larger PR #477 dep bundle. 9.0.1 ships mui/material-ui#48263 (resetInputValue change for freeSolo+null value); the goal here is to reproduce the observation-edit "pre-populates species" test failure and try fixes.
frewsxcv
force-pushed
the
investigate/mui-9.0.1
branch
from
8a949a3 to
42086b1
Compare
@mui/material 9.0.1 (mui/material-ui#48263) made `useAutocomplete`'s `resetInputValue` clear a non-empty `inputValue` when `value` is null and `freeSolo` is set. Our `inputValue` was controlled but `value` was not, so an async `setSpecies("Quercus alba")` in UploadModal's edit-mode useEffect was wiped before the user saw it. Controlling `value` alongside `inputValue` flips `isOptionSelected` to true, so the reset path short-circuits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Isolate the suspected breakage from PR #477's larger dep bundle. Only change is
@mui/materialand@mui/icons-materialpinned to9.0.1. If CI fails the sameobservation-edit "edit modal pre-populates species"test here, it's conclusively MUI 9.0.1 (and not React 19.2.6 / Playwright 1.60 / others).Hypothesis
9.0.1 ships mui/material-ui#48263 — a
resetInputValuechange forfreeSolo + value === null. OurTaxaAutocompleteisfreeSolowith uncontrolledvalue, which is the affected shape.Do not merge
This is investigation-only. Once we have a verdict, close it and decide whether to (a) patch
TaxaAutocompleteViewto also controlvalue, or (b) keep MUI pinned to 9.0.0 in #477.