[autocomplete] Fix input value and clear#48263
Merged
mj12albert merged 2 commits intoApr 14, 2026
Merged
Conversation
mj12albert
added
type: bug
Netlify deploy previewhttps://deploy-preview-48263--material-ui.netlify.app/ Bundle size report
|
mj12albert
force-pushed
the
autocomplete/fix-input-value-and-clear-2of5
branch
from
2e15ebf to
8e38a83
Compare
mj12albert
force-pushed
the
autocomplete/fix-input-value-and-clear-2of5
branch
from
8e38a83 to
f1cb316
Compare
silviuaavram
approved these changes
Apr 14, 2026
| expect(textbox).toHaveFocus(); | ||
|
|
||
| // Blur and re-focus: onOpen should be called (ignoreFocus was NOT set) | ||
| act(() => { |
Member
There was a problem hiding this comment.
would user.tab and user.tab({shift}) also work here?
Bundle size
Deploy previewhttps://deploy-preview-48263--material-ui.netlify.app/ Check out the code infra dashboard for more information about this PR. |
frewsxcv
added a commit
to observ-ing/core
that referenced
this pull request
May 19, 2026
9.0.1 ships a useAutocomplete change (mui/material-ui#48263) that clears the input in freeSolo/null-value scenarios. Our TaxaAutocomplete hits that path, which broke tests/observation-edit.spec.ts "edit modal pre-populates species".
frewsxcv
added a commit
to observ-ing/core
that referenced
this pull request
May 19, 2026
Isolates the suspected breakage from the larger PR #477 dep bundle. 9.0.1 ships mui/material-ui#48263 (resetInputValue change for freeSolo+null value); the goal here is to reproduce the observation-edit "pre-populates species" test failure and try fixes.
frewsxcv
added a commit
to observ-ing/core
that referenced
this pull request
May 19, 2026
@mui/material 9.0.1 (mui/material-ui#48263) made `useAutocomplete`'s `resetInputValue` clear a non-empty `inputValue` when `value` is null and `freeSolo` is set. Our `inputValue` was controlled but `value` was not, so an async `setSpecies("Quercus alba")` in UploadModal's edit-mode useEffect was wiped before the user saw it. Controlling `value` alongside `inputValue` flips `isOptionSelected` to true, so the reset path short-circuits.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40099
Fixes #43458
1. Clear-on-escape breaks subsequent open-on-focus #43458
Demo: https://deploy-preview-48263--material-ui.netlify.app/material-ui/react-autocomplete/#creatable
openOnFocusworks)With this fix: Popup opens on step 6
Without the fix: Popup doesn't open on step 6, the escape-clear breaks
focusOnOpenafterwards2. Controlled free solo input value doesn't clear #40099
Demo: https://stackblitz.com/edit/krui4i59-h253ekpy?file=src%2FDemo.tsx
With this fix: input is cleared
Without the fix: input not cleared (stackblitz)