Skip to content

Fix file picker overwriting other files without warning #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhecker merged 2 commits into from
May 26, 2025
Merged

Fix file picker overwriting other files without warning #277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c08573
Fix the filepicker replacing other files without warning
Ride-A-Pig May 26, 2025
4c7ab00
Fix the filepicker replacing files without warning
Ride-A-Pig May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/bin/edit/draw_filepicker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use edit::framebuffer::IndexedColor;
use edit::helpers::*;
use edit::input::vk;
use edit::tui::*;
use edit::{icu, path, sys};
use edit::{icu, path};

use crate::localization::*;
use crate::state::*;
Expand Down Expand Up @@ -114,9 +114,7 @@ pub fn draw_file_picker(ctx: &mut Context, state: &mut State) {
// Check if the file already exists and show an overwrite warning in that case.
if state.wants_file_picker != StateFilePicker::Open
&& let Some(path) = doit.as_deref()
&& let Some(doc) = state.documents.active()
&& let Some(file_id) = &doc.file_id
&& sys::file_id(None, path).is_ok_and(|id| &id == file_id)
&& path.exists()
{
state.file_picker_overwrite_warning = doit.take();
}
Expand Down