Fix file picker overwriting other files without warning#277
Merged
Conversation
lhecker
approved these changes
May 26, 2025
lhecker
left a comment
lhecker
left a comment
Member
There was a problem hiding this comment.
The actual bug in the old code is that the sys::file_id line is missing an ! in front of it. But...
Yeah, why did I overcomplicate this? 🤔
Yoink!
lhecker
changed the title
FilePicker
lhecker
added
C-bug
Contributor
Author
Besides that part, it seems impossible to get the file_id when a new document has not been saved yet. |
diabloproject
pushed a commit
to diabloproject/edit
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixed.
The
FilePickerwill just replace other files without warning if the doc's name is different from the name entered by the user.