Skip to content

refactor(http-request): bundle runtime dependencies#75

Merged
laipz8200 merged 3 commits intomainfrom
fp-http-request-deps
Apr 21, 2026
Merged

refactor(http-request): bundle runtime dependencies#75
laipz8200 merged 3 commits intomainfrom
fp-http-request-deps

Conversation

@laipz8200
Copy link
Copy Markdown
Member

@laipz8200 laipz8200 commented Apr 21, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Search existing issues and pull requests to confirm this change is not a duplicate
  3. Open or identify the issue this pull request resolves or advances
  4. Use a Conventional Commits title for this pull request, and mark breaking changes with !
  5. Remember that the pull request title will become the squash merge commit message
  6. If CLA Assistant prompts you, sign CLA.md in the pull request conversation

Related Issue

Refs #66

Summary

  • bundle the HTTP request node's runtime collaborators behind a module-local dependency helper
  • keep the legacy constructor keywords working while rejecting mixed old and new dependency input
  • keep the dependency helper off the package surface and update direct tests to exercise the internal path

Checklist

  • This pull request links the issue it resolves or advances
  • This pull request title follows Conventional Commits, and any breaking change is marked with !
  • If CLA Assistant prompted me, I signed CLA.md in the pull request conversation

Bundle HttpRequestNode runtime collaborators behind an explicit dependency object while keeping the legacy constructor path compatible.

Expose the new dependency bundle from the package surface and cover the new API plus mixed-input rejection in direct tests.
Rename the HTTP request node dependency container to a private module-local helper and stop exporting it from the package surface.

Keep the constructor compatibility path intact and adjust direct tests to exercise the internal dependency path without public imports.
@laipz8200 laipz8200 marked this pull request as ready for review April 21, 2026 05:25
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 21, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
@laipz8200 laipz8200 merged commit 7d53d21 into main Apr 21, 2026
5 checks passed
@laipz8200 laipz8200 deleted the fp-http-request-deps branch April 21, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants