Skip to content

refactor(question-classifier)!: bundle runtime dependencies#67

Merged
laipz8200 merged 5 commits intomainfrom
fp-question-classifier-deps
Apr 21, 2026
Merged

refactor(question-classifier)!: bundle runtime dependencies#67
laipz8200 merged 5 commits intomainfrom
fp-question-classifier-deps

Conversation

@laipz8200
Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Search existing issues and pull requests to confirm this change is not a duplicate
  3. Open or identify the issue this pull request resolves or advances
  4. Use a Conventional Commits title for this pull request, and mark breaking changes with !
  5. Remember that the pull request title will become the squash merge commit message
  6. If CLA Assistant prompts you, sign CLA.md in the pull request conversation

Related Issue

Refs #66

Summary

Bundle the question classifier node runtime collaborators behind a dedicated dependency object while keeping the legacy constructor keywords available for compatibility. Export the new dependency type and extend the node tests to cover bundled and legacy initialization paths.

Checklist

  • This pull request links the issue it resolves or advances
  • This pull request title follows Conventional Commits, and any breaking change is marked with !
  • If CLA Assistant prompted me, I signed CLA.md in the pull request conversation

@laipz8200 laipz8200 marked this pull request as ready for review April 21, 2026 04:16
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 21, 2026
@laipz8200 laipz8200 changed the title refactor(question-classifier): bundle runtime dependencies refactor(question-classifier)!: bundle runtime dependencies Apr 21, 2026
@laipz8200 laipz8200 enabled auto-merge (squash) April 21, 2026 05:54
Comment thread src/graphon/nodes/question_classifier/question_classifier_node.py Outdated
@laipz8200 laipz8200 assigned laipz8200 and 41tair and unassigned laipz8200 Apr 21, 2026
@laipz8200 laipz8200 merged commit 10a8f7a into main Apr 21, 2026
5 checks passed
@laipz8200 laipz8200 deleted the fp-question-classifier-deps branch April 21, 2026 10:24
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants