fix(train): skip EpisodeAwareSampler for streaming datasets#3501
Open
jashshah999 wants to merge 1 commit intohuggingface:mainfrom
Open
fix(train): skip EpisodeAwareSampler for streaming datasets#3501jashshah999 wants to merge 1 commit intohuggingface:mainfrom
jashshah999 wants to merge 1 commit intohuggingface:mainfrom
Conversation
PyTorch DataLoader forbids passing a sampler with IterableDataset. When training with --dataset.streaming=true and a policy that uses drop_n_last_frames (e.g. SARM), skip the sampler and log a warning that end-of-episode filtering is not available in streaming mode. Fixes huggingface#3436.
github-actions
Bot
added
the
configuration
jashshah999
force-pushed
the
fix/streaming-sampler-crash
branch
from
2333ffe to
3302472
Compare
github-actions
Bot
removed
the
configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Training with
--dataset.streaming=trueand a policy that usesdrop_n_last_frames(e.g. SARM) crashes withValueError: DataLoader with IterableDataset: expected unspecified sampler option.Fix: detect
IterableDatasetand skip theEpisodeAwareSampler, with a warning that end-of-episode filtering is not available in streaming mode.Test plan
lerobot-train --dataset.streaming=true --policy.type=sarmno longer crashesEpisodeAwareSampleras beforeFixes #3436.