fix(rl): ensure queue and process cleanup on abnormal exit#3063
Merged
pkooij merged 2 commits intohuggingface:mainfrom Apr 13, 2026
Merged
fix(rl): ensure queue and process cleanup on abnormal exit#3063pkooij merged 2 commits intohuggingface:mainfrom
pkooij merged 2 commits intohuggingface:mainfrom
Conversation
Wrap the main execution in actor_cli and start_learner_threads with try/finally so that queues are closed and processes are joined even when an unhandled exception occurs. Previously, exceptions in act_with_policy or add_actor_information_and_train would skip all cleanup code, leaking GPU/CPU resources. Also sets the shutdown_event on exception so child processes exit gracefully. Fixes huggingface#3059
s1lent4gnt
approved these changes
Apr 13, 2026
Member
s1lent4gnt
left a comment
s1lent4gnt
left a comment
There was a problem hiding this comment.
LGTM!
@jashshah999 Thank you for your contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Wraps the main execution in
actor_cliandstart_learner_threadswithtry/finallyso that queues are closed and processes are joined even when an unhandled exception occurs.Previously, if
act_with_policyoradd_actor_information_and_trainthrew an exception, all cleanup code was skipped -- leaking queues and child processes.Changes
actor.py: Wrapact_with_policy()call in try/finally, log exception, set shutdown_eventlearner.py: Wrapadd_actor_information_and_train()call in try/finally, log exception, set shutdown_eventFixes #3059