Adding changes to support tfpolicy_evaluations by subhro-acharjee-1 · Pull Request #1313 · hashicorp/go-tfe

subhro-acharjee-1 · 2026-04-21T08:33:54Z

Description

API endpoints related to tf-policy results needs to be implemented in go-tfe, so that terraform can read the structured response, and then use the information for displaying in the console output.

Note: Concrete structure in policy set and tests in policy set to create/update/delete tfpolicy policy sets are intentionally omitted. The tfpolicy feature is currently in beta and its behavior/interface is subject to change. Tests will be added once the feature stabilizes.

Testing plan

Create a local instance of atlas
Create a admin token
Create new workspace
Create new tfpolicy policy sets
Run the workspace
After evaluation is finished, call run.Read with include options for TFPolicyEvaluations
Use the tfPolicyEvaluation to call tfEvaluationOutcomes.List
Verify the result.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...

Rollback Plan

Changes to Security Controls

datadog-terraform-cloud-hashicorp · 2026-04-21T08:39:09Z

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 5dd75d0 | Docs | Give us feedback!}

Co-authored-by: Copilot <copilot@github.com>

…65-adding-support-for-tfpolicy-evaluations-outcome

Co-authored-by: Copilot <copilot@github.com>

shrishyamb

Added comments. In general please check the openapi spec for the Run, TFPolicyEvaluation and TFPolicySetOutcome API's for the updated fields.

shrishyamb · 2026-04-30T06:12:37Z

+)
+
+type TFPolicyEvaluationStatusTimestamps struct {
+	CanceledAt      time.Time `jsonapi:"attr,canceled-at,rfc3339"`


Refer spec for the status timestamp fields.

…evaluations-outcome

ctrombley

@subhro-acharjee-1, would you please address the comments I left here?

ctrombley · 2026-05-06T05:38:40Z

+
+type TFPolicyEvaluationResultCount struct {
+	AdvisoryFailed int `jsonapi:"attr,advisory-failed"`
+	MadatoryFailed int `jsonapi:"attr,mandatory-failed"`


nit:

Suggested change

MadatoryFailed int `jsonapi:"attr,mandatory-failed"`

MandatoryFailed int `jsonapi:"attr,mandatory-failed"`

ctrombley · 2026-05-06T05:39:40Z

+
+const (
+	TFPolicyEvaluationErrorTypeSetupError               TFPolicyEvaluationErrorType = "setup_error"
+	TFPolicyEvaluationErrorTypeIncompaitbleAgentVersion TFPolicyEvaluationErrorType = "incompatible_agent_version"


nit:

Suggested change

TFPolicyEvaluationErrorTypeIncompaitbleAgentVersion TFPolicyEvaluationErrorType = "incompatible_agent_version"

TFPolicyEvaluationErrorTypeIncompatbleAgentVersion TFPolicyEvaluationErrorType = "incompatible_agent_version"

ctrombley · 2026-05-06T05:40:02Z

+	AwaitingOverrideAt time.Time `jsonapi:"attr,awaiting-override-at,rfc3339"`
+	PassedAt           time.Time `jsonapi:"attr,passed-at,rfc3339"`
+	FailedAt           time.Time `jsonapi:"attr,failed-at,rfc3339"`
+	OverridenAt        time.Time `jsonapi:"attr,overridden-at,rfc3339"`


nit:

Suggested change

OverridenAt time.Time `jsonapi:"attr,overridden-at,rfc3339"`

OverriddenAt time.Time `jsonapi:"attr,overridden-at,rfc3339"`

ctrombley · 2026-05-06T05:43:09Z

+type TFPolicyEvaluationOutcomeEnforcementLevel string
+
+const (
+	TFPolicyEvaluationOutcomeEnforcementLevelAdvisory             TFPolicyEvaluationOutcomeEnforcementLevel = "advisory"
+	TFPolicyEvaluationOutcomeEnforcementLevelMandatory            TFPolicyEvaluationOutcomeEnforcementLevel = "mandatory"
+	TFPolicyEvaluationOutcomeEnforcementLevelMandatoryOverridable TFPolicyEvaluationOutcomeEnforcementLevel = "mandatory_overridable"
+)
+
+type TFPolicyEvaluationOutcomeStatus string
+
+const (
+	TFPolicyEvaluationOutcomeStatusPassed  TFPolicyEvaluationOutcomeStatus = "passed"
+	TFPolicyEvaluationOutcomeStatusFailed  TFPolicyEvaluationOutcomeStatus = "failed"
+	TFPolicyEvaluationOutcomeStatusErrored TFPolicyEvaluationOutcomeStatus = "errored"
+	TFPolicyEvaluationOutcomeStatusUnknown TFPolicyEvaluationOutcomeStatus = "unknown"
+)


Are these in use anywhere? If not, can we remove them?

TFPolicyEvaluationOutcomeEnforcementLevel is getting used in Outcome struct so cant remove it but i am removing the TFPolicyEvaluationOutcomeStatus

ctrombley · 2026-05-06T05:47:44Z

+)
+
+// NOTE: TFpolicy is still a beta feature and is subject to change.
+


Suggestion for consistency with other services in this repo:

Suggested change

// Compile-time proof of interface implementation.

var _ TFPolicyEvaluationOutcomes = (*tfPolicyEvaluationOutcomes)(nil)

ctrombley · 2026-05-06T05:52:19Z

+	if err := options.valid(); err != nil {
+		return nil, err
+	}


Consider removing this check and the called valid() method if it's just a no-op.

ctrombley · 2026-05-06T05:52:26Z

+func (s *TFPolicyEvaluationListOptions) valid() error {
+	return nil
+}


…lan subscription (#1317) * Update helper_test.go * Update CHANGELOG.md * print agent output upon failure * fix test * take out log * Update CHANGELOG.md

* adds admin scim groups resouce and integration test * fixed lint * updated changelog entry * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * updated changelog entry * addressed review comment * updated test cases names * updated integration test * added nil receiver guard in valid() fn * added page validation to pass lint * removed redundant test cases * use defaultPageSize const for pagination test * updated test case name --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ons (#1322) The no-code module workspace creation API accepts a terraform-version attribute, but the Go client struct was missing the field, making it impossible to specify a Terraform version at creation time. Add the field with an accurate doc comment (the fallback is the platform's latest available Terraform version, not an org-level default) and a corresponding integration test subcase that verifies the value roundtrips correctly through the API.

…-outcome' of github.com:hashicorp/go-tfe into subhro/TF-34065-adding-support-for-tfpolicy-evaluations-outcome

…evaluations-outcome

Co-authored-by: Chris Trombley <ctrombley@gmail.com>

Adding changes to support tfpolicy_evaluations

1118a94

subhro-acharjee-1 and others added 2 commits April 23, 2026 23:19

Adding change log and integration tests

d0820ca

Co-authored-by: Copilot <copilot@github.com>

Merge branch 'main' of github.com:hashicorp/go-tfe into subhro/TF-340…

3f3f512

…65-adding-support-for-tfpolicy-evaluations-outcome

subhro-acharjee-1 marked this pull request as ready for review April 23, 2026 18:04

subhro-acharjee-1 requested a review from a team as a code owner April 23, 2026 18:04

subhro-acharjee-1 and others added 2 commits April 28, 2026 18:03

Adding some minor fixes

b3175b1

Co-authored-by: Copilot <copilot@github.com>

adding comments to notify devs of beta features

11df4f3

shrishyamb requested changes Apr 30, 2026

View reviewed changes

addressing pr changes

0128e9b

shrishyamb requested changes May 4, 2026

View reviewed changes

Comment thread tfpolicy_evaluations.go Outdated

Comment thread tfpolicy_evaluations.go Outdated

Comment thread tfpolicy_evaluations.go Outdated

Comment thread tfpolicy_evaluations.go Outdated

shrishyamb reviewed May 4, 2026

View reviewed changes

Comment thread tfpolicy_evaluations.go Outdated

shrishyamb reviewed May 4, 2026

View reviewed changes

Comment thread tfpolicy_evaluations.go Outdated

shrishyamb reviewed May 4, 2026

View reviewed changes

Comment thread tfpolicy_evaluations.go Outdated

subhro-acharjee-1 added 3 commits May 4, 2026 12:02

addressing pr comments

2a9399b

Removing redundant structs

7129553

Merge branch 'main' into subhro/TF-34065-adding-support-for-tfpolicy-…

bf7ee7c

…evaluations-outcome

shrishyamb self-requested a review May 4, 2026 07:22

Merge branch 'main' into subhro/TF-34065-adding-support-for-tfpolicy-…

17e0cd8

…evaluations-outcome

ctrombley requested changes May 6, 2026

View reviewed changes

shwetamurali and others added 9 commits May 6, 2026 11:32

Fix TestAgentsList CI failure by setting agents-ceiling in Business p…

638b513

…lan subscription (#1317) * Update helper_test.go * Update CHANGELOG.md * print agent output upon failure * fix test * take out log * Update CHANGELOG.md

prep for v1.104.0 (#1326)

7d7a3b9

Fixing changelog and adding an example file

cb57895

Merge branch 'subhro/TF-34065-adding-support-for-tfpolicy-evaluations…

c8f9d07

…-outcome' of github.com:hashicorp/go-tfe into subhro/TF-34065-adding-support-for-tfpolicy-evaluations-outcome

Adding changes suggested in PR review

eafedde

Merge branch 'main' into subhro/TF-34065-adding-support-for-tfpolicy-…

149bcd3

…evaluations-outcome

Apply suggestion from @ctrombley

5dd75d0

Co-authored-by: Chris Trombley <ctrombley@gmail.com>

	MadatoryFailed int `jsonapi:"attr,mandatory-failed"`
	MandatoryFailed int `jsonapi:"attr,mandatory-failed"`

	TFPolicyEvaluationErrorTypeIncompaitbleAgentVersion TFPolicyEvaluationErrorType = "incompatible_agent_version"
	TFPolicyEvaluationErrorTypeIncompatbleAgentVersion TFPolicyEvaluationErrorType = "incompatible_agent_version"

	OverridenAt time.Time `jsonapi:"attr,overridden-at,rfc3339"`
	OverriddenAt time.Time `jsonapi:"attr,overridden-at,rfc3339"`

		)

		// NOTE: TFpolicy is still a beta feature and is subject to change.



	// Compile-time proof of interface implementation.
	var _ TFPolicyEvaluationOutcomes = (*tfPolicyEvaluationOutcomes)(nil)

Conversation

subhro-acharjee-1 commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing plan

External links

Output from tests

Rollback Plan

Changes to Security Controls

Uh oh!

datadog-terraform-cloud-hashicorp Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shrishyamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ctrombley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

subhro-acharjee-1 commented Apr 21, 2026 •

edited

Loading

datadog-terraform-cloud-hashicorp Bot commented Apr 21, 2026 •

edited

Loading