Fix TestAgentsList CI failure by setting agents-ceiling in Business plan subscription#1317
Merged
shwetamurali merged 6 commits intomainfrom Apr 28, 2026
Merged
Fix TestAgentsList CI failure by setting agents-ceiling in Business plan subscription#1317shwetamurali merged 6 commits intomainfrom
shwetamurali merged 6 commits intomainfrom
Conversation
TestAgentsList CI failure by updating tfc-agent to v1.28.7
Uk1288
approved these changes
Apr 28, 2026
Maed223
approved these changes
Apr 28, 2026
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
subhro-acharjee-1
pushed a commit
that referenced
this pull request
May 6, 2026
…lan subscription (#1317) * Update helper_test.go * Update CHANGELOG.md * print agent output upon failure * fix test * take out log * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TestAgentsListandTestAgentsReadhave been failing in CI, blocking all PRs. The agent process exits immediately with the message "Cannot register more than 0 agents in your organization." The cause is that TFC was updated to enforce an explicit agent count ceiling on organization subscriptions. Previously, upgrading an org to the "Business" plan implicitly allowed agents. Now the server defaults the agent ceiling to 0 unlessagents-ceilingis explicitly set in the subscription update. OurupgradeOrganizationSubscriptionhelper setsruns-ceiling,contract-user-limit, etc. but never set an agent ceiling so I addedAgentsCeilingfield toupdateFeatureSetOptionsand set it to 10. This ensures test orgs are provisioned with capacity to register agents.Testing plan
TestAgentsListandTestAgentsReadwithout retriesskipUnlessLinuxAMD64Rollback Plan
We can revert the change