Skip to content

Fix TestAgentsList CI failure by setting agents-ceiling in Business plan subscription#1317

Merged
shwetamurali merged 6 commits intomainfrom
shweta/unblock_ci
Apr 28, 2026
Merged

Fix TestAgentsList CI failure by setting agents-ceiling in Business plan subscription#1317
shwetamurali merged 6 commits intomainfrom
shweta/unblock_ci

Conversation

@shwetamurali
Copy link
Copy Markdown
Contributor

@shwetamurali shwetamurali commented Apr 28, 2026

Description

TestAgentsList and TestAgentsRead have been failing in CI, blocking all PRs. The agent process exits immediately with the message "Cannot register more than 0 agents in your organization." The cause is that TFC was updated to enforce an explicit agent count ceiling on organization subscriptions. Previously, upgrading an org to the "Business" plan implicitly allowed agents. Now the server defaults the agent ceiling to 0 unless agents-ceiling is explicitly set in the subscription update. Our upgradeOrganizationSubscription helper sets runs-ceiling, contract-user-limit, etc. but never set an agent ceiling so I added AgentsCeiling field to updateFeatureSetOptions and set it to 10. This ensures test orgs are provisioned with capacity to register agents.

Testing plan

  • CI should pass TestAgentsList and TestAgentsRead without retries
  • Cannot reproduce locally since tests are gated behind skipUnlessLinuxAMD64

Rollback Plan

We can revert the change

@datadog-terraform-cloud-hashicorp
Copy link
Copy Markdown

datadog-terraform-cloud-hashicorp Bot commented Apr 28, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b57efe9 | Docs | Give us feedback!

@shwetamurali shwetamurali added the no-changelog-needed check changelog entry github workflow label Apr 28, 2026
@shwetamurali shwetamurali marked this pull request as ready for review April 28, 2026 16:02
@shwetamurali shwetamurali requested a review from a team as a code owner April 28, 2026 16:02
@shwetamurali shwetamurali changed the title Fix TestAgentsList CI failure by updating tfc-agent to v1.28.7 Fix TestAgentsList CI failure by setting agents-ceiling in Business plan subscription Apr 28, 2026
@shwetamurali shwetamurali merged commit 187e68d into main Apr 28, 2026
17 of 18 checks passed
@shwetamurali shwetamurali deleted the shweta/unblock_ci branch April 28, 2026 17:02
@github-actions
Copy link
Copy Markdown

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

subhro-acharjee-1 pushed a commit that referenced this pull request May 6, 2026
…lan subscription (#1317)

* Update helper_test.go

* Update CHANGELOG.md

* print agent output upon failure

* fix test

* take out log

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed check changelog entry github workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants