trigger only one event when calling removeAll()#551
Closed
sthuck wants to merge 2 commits intogridstack:developfrom
sthuck:master
Closed
trigger only one event when calling removeAll()#551sthuck wants to merge 2 commits intogridstack:developfrom sthuck:master
sthuck wants to merge 2 commits intogridstack:developfrom
sthuck:master
Conversation
Member
|
I'm not sure if this is the right way to go or not. I think about this every so often. It haunts me. I can understand both sides. |
2 tasks
Member
|
thank you for the suggestion - I ended up checking in a better solution #1097 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
Currently when calling removeAll(), the 'removed' event get triggered for every item on the grid, and it passes only one item to the event handler. I think a more logical behavior is triggering the event only once. Otherwise, there isn't really a point for '_removedNodes' on GridStackEngine. Hope you'll find this change needed.