Skip to content

much faster removeAll(), single event trigger#1097

Merged
adumesny merged 2 commits intogridstack:developfrom
adumesny:develop
Dec 17, 2019
Merged

much faster removeAll(), single event trigger#1097
adumesny merged 2 commits intogridstack:developfrom
adumesny:develop

Conversation

@adumesny
Copy link
Copy Markdown
Member

@adumesny adumesny commented Dec 17, 2019

Description

  • removeAll() is now much faster as it doesn't cause any relayout (added GridStackEngine.removeAll to optimize)
  • it now calls removed event back just once with a list of nodes
  • _removedNodes uses actual nodes (not clones)

better fix than #551, related to previous #1096

Checklist

  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

much faster removeAll(), single event trigger
1c77147 
* `removeAll()` is now much faster as it doesn't cause any relayout (added GridStackEngine.removeAll to optimize)
* it now calls `removed` event back just once with a list of nodes
* _removedNodes uses actualy nodes (not clones)

better fix than #551, related to previous #1096
@adumesny adumesny mentioned this pull request Dec 17, 2019
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 17, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 66.703% when pulling f7e46c5 on adumesny:develop into bf28a78 on gridstack:develop.

@adumesny adumesny merged commit 5035a18 into gridstack:develop Dec 17, 2019
@HiroyasuNishiyama HiroyasuNishiyama mentioned this pull request Mar 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adumesny @coveralls