Merged
Conversation
tseaver
added
do not merge
googlebot
added
the
cla: yes
tseaver
added
release blocking
tseaver
force-pushed
the
spanner-dml-prep_for_public
branch
2 times, most recently
from
05dc94b to
1d3d8fb
Compare
With DML statements, there may be no explicit mutations tracked on the client side.
Switch the still-failing system test to use it.
Assert that stats have appropriate row count.
Required for executing multiple DML statements w/in context of one transaction. Update system tests for DML to exercise this (they previously passed only one statement).
- Rollback transaction after performing DML. - Mix DML and batch-style mutations in a single commit.
Also, drop the 'partition' argument to it: not appropriate to the usecase.
* Add 'Datatbase.execute_partitioned_dml' method. * Add system test which exercises PDML. both for UPDATE (with parameter) and DELETE.
tseaver
force-pushed
the
spanner-dml-prep_for_public
branch
from
1d3d8fb to
d8a714d
Compare
tseaver
removed
do not merge
tseaver
added a commit
that referenced
this pull request
Oct 3, 2018
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
- Add 'Transaction.execute_update' method. - Add required integration test cases for non-partitioned DML: - Rollback transaction after performing DML. - Mix DML and batch-style mutations in a single commit. - Add 'Datatbase.execute_partitioned_dml' method. - Add system test which exercises PDML. both for UPDATE (with parameter) and DELETE.
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @snehashah16
DML / PDML system tests will fail until the production endpoint support is rolled out. Do not merge until then.