Skip to content

Commit d8a714d

Browse files
committed
Review comment: PDML does not support query mode.
1 parent 7660f40 commit d8a714d

2 files changed

Lines changed: 2 additions & 9 deletions

File tree

spanner/google/cloud/spanner_v1/database.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ def drop(self):
280280
api.drop_database(self.name, metadata=metadata)
281281

282282
def execute_partitioned_dml(
283-
self, dml, params=None, param_types=None, query_mode=None):
283+
self, dml, params=None, param_types=None):
284284
"""Execute a partitionable DML statement.
285285
286286
:type dml: str
@@ -295,11 +295,6 @@ def execute_partitioned_dml(
295295
(Optional) maps explicit types for one or more param values;
296296
required if parameters are passed.
297297
298-
:type query_mode:
299-
:class:`google.cloud.spanner_v1.proto.ExecuteSqlRequest.QueryMode`
300-
:param query_mode: Mode governing return of results / query plan. See
301-
https://cloud.google.com/spanner/reference/rpc/google.spanner.v1#google.spanner.v1.ExecuteSqlRequest.QueryMode1
302-
303298
:rtype: int
304299
:returns: Count of rows affected by the DML statement.
305300
"""
@@ -333,7 +328,6 @@ def execute_partitioned_dml(
333328
transaction=txn_selector,
334329
params=params_pb,
335330
param_types=param_types,
336-
query_mode=query_mode,
337331
metadata=metadata)
338332

339333
iterator = _restart_on_unavailable(restart)

spanner/tests/unit/test_database.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ def _execute_partitioned_dml_helper(
669669
api.execute_streaming_sql.return_value = iterator
670670

671671
row_count = database.execute_partitioned_dml(
672-
dml, params, param_types, query_mode=MODE)
672+
dml, params, param_types)
673673

674674
self.assertEqual(row_count, 2)
675675

@@ -696,7 +696,6 @@ def _execute_partitioned_dml_helper(
696696
transaction=expected_transaction,
697697
params=expected_params,
698698
param_types=param_types,
699-
query_mode=MODE,
700699
metadata=[('google-cloud-resource-prefix', database.name)],
701700
)
702701

0 commit comments

Comments
 (0)