Skip to content

fix: address agentd backlog feedback#48

Merged
haasonsaas merged 1 commit intomainfrom
codex/postmerge-feedback-sweep-20260429
Apr 29, 2026
Merged

fix: address agentd backlog feedback#48
haasonsaas merged 1 commit intomainfrom
codex/postmerge-feedback-sweep-20260429

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • add a typed EvalOpsContextMetadata helper for canonical evalops.context.v1 metadata cleanup and Secret Broker metadata construction
  • harden local batch persistence/replay so failed local writes return failed, pipeline batches remain pending for retry, and replay no longer runs retention sweeps between queued files
  • fix packaging/release feedback: explicit CFBundleExecutable, regenerate notarized zip after stapling, boolean notarized metadata, artifact-root checksums, and permission smoke authority parsing
  • tighten secret scrub patterns for modern OpenAI keys and Discord false positives; correct heartbeat pending-frame accounting and remove duplicate policy reconcile refreshes

Backlog / feedback covered

Validation

  • swift test
  • swift build -Xswiftc -warnings-as-errors
  • xcrun swift-format lint --strict --recursive Sources Tests Package.swift
  • python3 scripts/mock_chronicle.py --self-test Tests/Fixtures/chronicle
  • shellcheck scripts/package_app.sh scripts/permission_smoke.sh
  • actionlint .github/workflows/package-release.yml
  • scripts/package_app.sh
  • scripts/permission_smoke.sh --no-launch
  • git diff --check

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 29, 2026

PR Summary

Cursor Bugbot is generating a summary for commit c47f483. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit c47f483. Configure here.

Comment thread Sources/agentd/EvalOpsContextMetadata.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt shared evalops.context.v1 metadata helper

1 participant