Skip to content

Add permission smoke helper#27

Merged
haasonsaas merged 1 commit intomainfrom
codex/agentd-permission-smoke-20260427
Apr 27, 2026
Merged

Add permission smoke helper#27
haasonsaas merged 1 commit intomainfrom
codex/agentd-permission-smoke-20260427

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • add scripts/permission_smoke.sh to package the app, record checksum/macOS/codesign evidence, and write a hardware smoke report template
  • support --no-launch for non-invasive evidence generation and default launch for an intentional desktop smoke
  • document the helper next to the packaging commands

Testing

  • scripts/permission_smoke.sh --help
  • scripts/permission_smoke.sh --no-launch
  • shellcheck scripts/package_app.sh scripts/permission_smoke.sh
  • swift test
  • swift build -Xswiftc -warnings-as-errors
  • xcrun swift-format lint --strict --recursive Sources Tests Package.swift
  • git diff --check

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 27, 2026

PR Summary

Low Risk
Low risk: adds a standalone shell helper and README documentation, without changing app runtime behavior or build outputs beyond generating an optional report file.

Overview
Adds scripts/permission_smoke.sh to automate permission smoke testing: it ensures the app is packaged (calling scripts/package_app.sh if needed), captures SHA/codesign/macOS metadata, and writes a dist/permission-smoke-report.md checklist, optionally launching the app unless --no-launch is provided.

Updates README.md to document the new helper alongside existing build/packaging commands and describe what evidence it collects.

Reviewed by Cursor Bugbot for commit 3ef305e. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit 9806c9b into main Apr 27, 2026
4 checks passed
@haasonsaas haasonsaas deleted the codex/agentd-permission-smoke-20260427 branch April 27, 2026 16:25
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 3ef305e. Configure here.

Comment thread scripts/permission_smoke.sh
Comment thread scripts/permission_smoke.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant