chore(desktop): make proxy setup order explicit#25853
Open
Hona wants to merge 2 commits intoanomalyco:devfrom
Open
chore(desktop): make proxy setup order explicit#25853Hona wants to merge 2 commits intoanomalyco:devfrom
Hona wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes Desktop’s embedded server startup order explicit by removing the spawnLocalServer “configure env” callback and moving environment/proxy setup into the main startup flow before importing/spawning the embedded server (follow-up to #25846).
Changes:
- Removed the optional
configureEnvcallback parameter fromspawnLocalServer. - Exported
prepareServerEnvso Desktop startup can set server-related env before importingvirtual:opencode-server. - Updated Desktop initialization to explicitly run:
prepareServerEnv→ preserve loopbackNO_PROXY→ enable Node env proxy → then spawn the embedded server.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/desktop/src/main/server.ts | Removes callback-based env setup from spawnLocalServer and exports prepareServerEnv for explicit ordering. |
| packages/desktop/src/main/index.ts | Calls prepareServerEnv, ensureLoopbackNoProxy, and useEnvProxy explicitly before importing/spawning the embedded server. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+172
to
+176
| const url = `http://${hostname}:${port}` | ||
| const password = randomUUID() | ||
| prepareServerEnv(password) | ||
| ensureLoopbackNoProxy() | ||
| useEnvProxy() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawnLocalServer.Follow-up to #25846.
Testing