fix(desktop): respect proxy environment#25846
Merged
Hona merged 3 commits intoanomalyco:devfrom May 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Desktop main process startup to enable Node’s environment-driven proxy handling (HTTP_PROXY / HTTPS_PROXY / NO_PROXY) before the embedded server is started, addressing proxy-related failures in GitHub Copilot authentication on Windows.
Changes:
- Call a new
useEnvProxy()hook duringsetupApp()startup. - Add a
useEnvProxy()helper that invokes Node’shttp.setGlobalProxyFromEnv()(when available) and logs a warning on failure. - Import
node:httpto access the Node proxy bootstrap API.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
66 tasks
oleksii-honchar
pushed a commit
to oleksii-honchar/better-opencode
that referenced
this pull request
May 6, 2026
thdxr
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25843
Testing