You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pre-merge review finding: the new whiteboard drawing toolbar state is not mutually exclusive with the existing pointer selection mode. The test currently proves the problem: after clicking Freehand and then PART_PointerModeLassoButton, SelectionMode becomes Lasso but WhiteboardDrawingMode remains Freehand. In the actual pointer coordinator from PR #233, whiteboard drawing is checked before canvas selection, so the next left-drag will still create a whiteboard primitive instead of performing lasso selection.
This makes the UI misleading: the user appears to have switched back to lasso/selection, but the active whiteboard mode still intercepts the canvas. Please clear WhiteboardDrawingMode when selecting Marquee/Lasso, or model the tool mode as a single mutually exclusive state. Add a regression test that switching from Rectangle/Freehand back to Lasso/Marquee makes subsequent canvas drag follow selection rather than whiteboard drawing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphEditorViewauthoring toolbar.whiteboard-authoring-cookbook-route.Test Plan
dotnet test tests\AsterGraph.Editor.Tests\AsterGraph.Editor.Tests.csproj -c Release --verbosity minimal(877/877)dotnet test tests\AsterGraph.Demo.Tests\AsterGraph.Demo.Tests.csproj -c Release --verbosity minimal(299/299)dotnet test tests\AsterGraph.Demo.Tests\AsterGraph.Demo.Tests.csproj -c Release --filter "Cookbook|ReactFlowParityRoadmapDocsTests" --verbosity minimal(140/140)dotnet test tests\AsterGraph.Demo.Tests\AsterGraph.Demo.Tests.csproj -c Release --filter "ShellVisualCoveragePlanningDocsTests|PublicDocs_DoNotNameExternalInspirationProjects|ParityRoadmapDocs_RecordPhase554WhiteboardAuthoringCookbookUxRouteInBothLocales|CookbookCatalog_AddsWhiteboardAuthoringCookbookRoute" --verbosity minimal(10/10).\eng\validate-public-api-surface.ps1 -Configuration Release -Framework net9.0git diff --checkreact flow|xyflow|svelte flow|@xyflow|xy flowin README/public launch/Cookbook docs (no matches)Stack / Merge Order
feature/phase-553-whiteboard-pointer-gestures.Closes #228.