Merged
Conversation
2752313 to
01dfccc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
+ Coverage 73.13% 73.21% +0.07%
==========================================
Files 252 252
Lines 35959 35942 -17
==========================================
+ Hits 26300 26314 +14
+ Misses 9659 9628 -31
|
BenchmarksComparisonBenchmark execution time: 2024-09-13 06:57:11 Comparing candidate commit 01dfccc in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
bantonsson
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable the demangler feature when building artifacts on Gitlab.
Motivation
Since #551,
ddog_crasht_demangleis not include in the sofile. A fix was provided for github which uses the new builder. But in GitLab we still rely on thebuild-profiling.shshell script.Additional Notes
🤷♂️
How to test the change?
download the artifact from gitlab and check the presence of
ddog_crasht_demangle