[crashtracker] Move FFI to its own crate#551
Merged
Conversation
github-actions
Bot
added
profiling
danielsn
commented
Jul 26, 2024
danielsn
force-pushed
the
dsn/crashtrack-own-ffi
branch
from
827d908 to
0411e84
Compare
BenchmarksThis comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output. |
ivoanjo
reviewed
Jul 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
==========================================
+ Coverage 70.44% 70.45% +0.01%
==========================================
Files 213 213
Lines 28455 28448 -7
==========================================
Hits 20044 20044
+ Misses 8411 8404 -7
|
ivoanjo
reviewed
Jul 30, 2024
Member
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
So since we're moving things around, I did a deeper-dive review with a big focus on the APIs.
Since a lot of my comments are around names and consolidating stuff, I hope you don't take it as too much of a bikeshed. If it sounds like that at times, sorry in advance! 🙏
Do feel free to push back on any comments you don't agree with and don't feel blocked by them :)
This was referenced Jul 31, 2024
Co-authored-by: Ivo Anjo <ivo.anjo@datadoghq.com>
…or Azure Functions, Google Cloud Functions, and Azure Spring Apps (#548) * add _dd.mini_agent_version to spans in all environments * apply formatting
* add azure spring app environment type for serverless mini agent * add config.statsd_port to mini agent info endpoint * update mini agent trace endpoint status code and response body to work with java tracer * use different environment variable to identify azure spring apps * only update http response for success responses to traces endpoint * address lint errors * updates comment and formatting * update trace-mini-agent description to include Azure Spring Apps * fix formatting
This was referenced Jul 31, 2024
ivoanjo
approved these changes
Aug 1, 2024
Member
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
👍 LGTM, thanks for addressing my comments so thoroughly!
Co-authored-by: Ivo Anjo <ivo.anjo@datadoghq.com>
This was referenced Aug 1, 2024
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the crashtracker FFI to its own crate, seperate from Profiling.
Motivation
Consumers want to use crashtracking without profiling. This is a step in this direction.
Additional Notes
How to test the change?
Run the existing test suite, plus the FFI examples
PROF-10245