Skip to content

Append permissions to work around TF provider issue#52

Merged
DariuszPorowski merged 3 commits into
mainfrom
manisbindra/add-special-handling-for-application-insights
Mar 6, 2025
Merged

Append permissions to work around TF provider issue#52
DariuszPorowski merged 3 commits into
mainfrom
manisbindra/add-special-handling-for-application-insights

Conversation

@maniSbindra

@maniSbindra maniSbindra commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Fixes #49

  • This is to workaround the Terraform azurerm provider, Application Insights resource Issue . As a workaround, the utility automatically appends missing required permissions when Microsoft.Insights/components/read or Microsoft.Insights/components/write permissions are detected as missing permissions.
    When Microsoft.Insights/components/read is detected Microsoft.Insights/components/currentbillingfeatures/read and Microsoft.AlertsManagement/smartDetectorAlertRules/read permissions are appended. Similarly, when Microsoft.Insights/components/write is detected Microsoft.Insights/components/currentbillingfeatures/write and Microsoft.AlertsManagement/smartDetectorAlertRules/write permissions are appended.
  • Implement functionality to append permissions in such special cases (currently aware of only one such case)
  • Add Unit Tests
  • Modify app insights e2e test to reflect added permissions
  • Modify docs

@maniSbindra maniSbindra requested a review from a team as a code owner March 6, 2025 11:25

@DariuszPorowski DariuszPorowski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DariuszPorowski DariuszPorowski added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 411359f Mar 6, 2025
@DariuszPorowski DariuszPorowski deleted the manisbindra/add-special-handling-for-application-insights branch March 6, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additional permissions when Microsoft.Insights/components/read detected

2 participants