vibe code fixes for existing issues#27
Open
willianba wants to merge 2 commits into
Open
Conversation
willianba
commented
Nov 23, 2025
willianba
commented
Owner
- fix: replace forEach with Promise.all to prevent silent async failures
- skip serena folder
This commit fixes two critical bugs that could cause data corruption: 1. **forEach with async functions (CRITICAL)** - Changed forEach to map + Promise.all in expense update/delete - forEach doesn't wait for async functions, causing silent failures - Errors inside forEach async callbacks were being swallowed - Database could end up in inconsistent state with partial updates 2. **Date mutation bug** - Fixed direct mutation of expense.payment.date object - Now creates new Date instance to prevent side effects - Prevents race conditions in concurrent updates 3. **Code quality improvement** - Simplified getInstallmentDate() to avoid triple Date construction - More readable and performant date handling Impact: - Recurring expense updates now properly fail-fast if any update fails - All correlated expenses update atomically as a group - Date mutations no longer affect original objects - Better error propagation to user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.