This repository was archived by the owner on Mar 16, 2020. It is now read-only.
Add TypeScript declarations to support Webpack configurations written in TypeScript as well#86
Open
jsievenpiper wants to merge 1 commit intowebpack-contrib:masterfrom
Open
Add TypeScript declarations to support Webpack configurations written in TypeScript as well#86jsievenpiper wants to merge 1 commit intowebpack-contrib:masterfrom
jsievenpiper wants to merge 1 commit intowebpack-contrib:masterfrom
Conversation
… in TypeScript as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple start at hashing out the simpler parts of declaring TypeScript interfaces for consumers of
babel-minify-webpack-plugin. This allows end-users to leverage this plugin in a TypeScript-authored Webpack config file:There were a couple cases where the plugin was being extremely robust to support just about any value passed in as a fallback (typically via boolean coercion) that isn't explicitly listed in the types (otherwise they'd fall down to TypeScript's
any).