Skip to content

Add BitBuffer to vortex-buffer#4937

Merged
gatesn merged 3 commits into
developfrom
ngates/bit-buffer
Oct 13, 2025
Merged

Add BitBuffer to vortex-buffer#4937
gatesn merged 3 commits into
developfrom
ngates/bit-buffer

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Oct 13, 2025

Pulled from #2456

This separates out the logic of adding the BitBuffer from using it. There are some outstanding performance issues before we can pick up #2456 again.

I added some benchmarks that highlight where we're slower than Arrow atm

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested review from a10y and robert3005 October 13, 2025 19:09
@gatesn gatesn added the changelog/feature A new feature label Oct 13, 2025
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 34.74676% with 554 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.02%. Comparing base (46e2538) to head (467ea8a).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-buffer/src/bit/buf.rs 31.64% 162 Missing ⚠️
vortex-buffer/src/bit/unaligned.rs 31.40% 142 Missing ⚠️
vortex-buffer/src/bit/buf_mut.rs 52.04% 94 Missing ⚠️
vortex-buffer/src/bit/ops.rs 0.00% 81 Missing ⚠️
vortex-buffer/src/bit/aligned.rs 0.00% 64 Missing ⚠️
vortex-buffer/src/buffer.rs 73.33% 8 Missing ⚠️
vortex-buffer/src/bit/mod.rs 50.00% 3 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) October 13, 2025 19:45
@gatesn gatesn merged commit 5694288 into develop Oct 13, 2025
39 checks passed
@gatesn gatesn deleted the ngates/bit-buffer branch October 13, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants