feat: Remove 'parquet' feature and some other dependency bloat#4251
Merged
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
changed the title
github-actions
Bot
removed
the
action/benchmark-sql
CodSpeed Performance ReportMerging #4251 will improve performances by 13.99%Comparing Summary
Benchmarks breakdown
|
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/minimize-deps
branch
from
56400f2 to
30e27bc
Compare
robert3005
reviewed
Aug 15, 2025
Contributor
Benchmarks: TPC-H SF=1 on NVMETable of Results
|
Contributor
|
with #2456 and moving compute functions out of core crate we could remove all of arrow from critical path |
robert3005
approved these changes
Aug 15, 2025
Contributor
Benchmarks: TPC-H SF=1 on S3Table of Results
|
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMETable of Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step in the right direction, removes two of our slowest-to-build dependencies which are not really needed. I just re-implemented the cast logic we care about and parquet was just there for an error variant.
To measure the difference, I ran
cargo clean; cargo build --release -p vortex --timings --all-featuresCurrently on develop
vortexhas 413 dependencies, with the top 10 in build time being:With this PR it has 327 dependencies and the top 10 are:
arrow-ordandarrow-selectdo some heavier lifting that I think will be harder to replace, but we should also do that at some point.