fix(vitest): show beforeAll/afterAll errors in junit reporter#4819
Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom Dec 31, 2023
Merged
fix(vitest): show beforeAll/afterAll errors in junit reporter#4819sheremet-va merged 1 commit intovitest-dev:mainfrom
beforeAll/afterAll errors in junit reporter#4819sheremet-va merged 1 commit intovitest-dev:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4516
This PR is an alternative of #4799 to surface beforeAll/afterAll errors in junit reporter.
This approach might not be the most sound one since it "mutates" test counts when beforeAll/afterAll failed, but this will ensure such suite-level errors will be recorded in the report.
The idea came from how default reporters shows "Failed Suites" separately from "Failed Tests":
vitest/packages/vitest/src/node/reporters/base.ts
Lines 290 to 302 in 5ee041d
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.