test(core): cover cancel run spec version#2004
Conversation
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
🦋 Changeset detectedLatest commit: befdf1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@EfeDurmaz16 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
35eb48f to
04eac55
Compare
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
0ca6dfd to
befdf1e
Compare
|
Thanks for the review. I dropped the Verification:
Note: the broader |
Description
Adds regression coverage for
cancelRun()so Vercel-backed cancellation keeps sending arun_cancelledevent with the target run'sspecVersion. This protects the issue #1076 path where the Vercel backend rejected cancellation payloads that were missing versioned event fields.Also covers the legacy fallback path to ensure runs without a stored spec version still use the v1-compatible cancellation endpoint.
While refreshing the PR, I also fixed the Local Postgres E2E setup race visible in recent CI runs. Multiple matrix jobs were starting Graphile migrations concurrently and failing with duplicate Postgres schema / migration rows, so the Postgres queue startup now serializes Graphile migration work behind a Postgres advisory lock held on a single client.
Closes #1076.
How did you test your changes?
corepack pnpm exec vitest run packages/core/src/runtime/runs.test.tscorepack pnpm exec biome check packages/core/src/runtime/runs.test.tscorepack pnpm --filter @workflow/core typecheckcorepack pnpm exec vitest run packages/world-postgres/src/queue.test.tscorepack pnpm exec biome check packages/world-postgres/src/queue.ts packages/world-postgres/src/queue.test.tscorepack pnpm --filter @workflow/world-postgres typecheckNote:
corepack pnpm turbo run build --filter='!./workbench/*'was blocked locally by a missing Rustwasm32-unknown-unknowntarget in@workflow/swc-plugin; the targeted Postgres and core checks above pass locally.PR Checklist - Required to merge
pnpm changesetwas run to create a changelog for this PRpnpm changeset --emptybecause the original change is test-only.git commit --signoffon your commits)@vercel/workflowin a comment once the PR is ready, and the above checklist is complete