Added nullable enums support#41
Open
m0a0k0s wants to merge 1 commit intounchase:masterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for nullable enum types in the Swashbuckle AspNetCore extensions by detecting and extracting the underlying enum type from nullable wrappers before processing.
Key Changes:
- Nullable enum type handling in schema and parameter filters using
Nullable.GetUnderlyingType() - Consistent use of the underlying enum type for generating enum names and descriptions
- Filtering of
OpenApiNullelements when processing enum documentation to maintain alignment with extension arrays
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| XEnumNamesSchemaFilter.cs | Extracts underlying type from nullable enums and uses it consistently for enum name and description generation |
| XEnumNamesParameterFilter.cs | Adds nullable enum type detection for parameter filtering |
| EnumTypeExtensions.cs | Filters out null elements from schema.Enum collection to ensure proper alignment with extension arrays that contain only actual enum values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.