Remove broken total count from workflow version#20324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a workflow run with a form step in the side panel, closing the form and reopening it crashes the app:
<SidePanelWorkflowStepInfo>blows up onworkflow.versions.findbecauseversionsisnullin the Apollo cache.Root cause
useWorkflowVersionwas selecting:Twenty's GraphQL field generator doesn't support connection-level scalars — { totalCount: true } is interpreted as fields on the inner WorkflowVersion node, gets filtered out, and the query collapses to:
versions { edges { node { __typename } } }
The server returns versions: null for that empty-node selection.
Why now
The selection has always been wrong, but two recent changes made it consistently surface:
Apollo Client v4 upgrade (#18584): stricter normalized writes, null always wins.
#20242: WorkflowRunSSESubscribeEffect in the form filler keeps SSE flowing, which re-fires useWorkflowVersion more often, making the bad query consistently the last writer.