Skip to content

feat: add overrides option for custom rectdiff ONLY AutoroutingPipelineSolver4_TinyHypergraph#1093

Open
0hmX wants to merge 2 commits intomainfrom
0hmx/new-overrides-option
Open

feat: add overrides option for custom rectdiff ONLY AutoroutingPipelineSolver4_TinyHypergraph#1093
0hmX wants to merge 2 commits intomainfrom
0hmx/new-overrides-option

Conversation

@0hmX
Copy link
Copy Markdown
Contributor

@0hmX 0hmX commented May 4, 2026

Expose rectdiff through a new overrides option so callers can pass a custom rectdiff implementation. This makes it easier to test inside the rectdiff solver repo by using a local rectdiff version.

0hmX added 2 commits May 4, 2026 15:55
Expose rectdiff through a new overrides option so callers can pass a custom rectdiff implementation. This makes it easier to test inside the rectdiff solver repo by using a local rectdiff version.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
capacity-node-autorouter Ready Ready Preview, Comment May 4, 2026 10:33am

Request Review

@tscircuitbot
Copy link
Copy Markdown
Contributor

🏃 Benchmark This PR

Run benchmarks by commenting on this PR:

/benchmark [benchmark.sh args...]
/benchmark [solver-name|all] [scenario-limit] --concurrency <n> --effort <n> --dataset <dataset01|zdwiel|srj05> [--profile-solvers]

Everything after /benchmark is forwarded directly to ./benchmark.sh, except --profile-solvers, which adds main/PR profile comparison tables to the result comment.

Examples:

  • /benchmark -> AutoroutingPipelineSolver4, all scenarios (default concurrency uses the benchmark runner CPU count)
  • /benchmark AutoroutingPipelineSolver4 -> one solver, all scenarios
  • /benchmark all 20 -> all solvers, first 20 scenarios
  • /benchmark AutoroutingPipelineSolver4 20 --concurrency 8 -> one solver, 20 scenarios, 8 workers
  • /benchmark AutoroutingPipelineSolver4 20 --effort 2 -> one solver, 20 scenarios, 2x effort
  • /benchmark AutoroutingPipelineSolver4 --dataset zdwiel -> one solver, all scenarios, zdwiel dataset
  • /benchmark AutoroutingPipelineSolver4 --dataset srj05 -> one solver, all scenarios, srj05 dataset
  • /benchmark all 20 --dataset dataset01 --concurrency 8 -> all solvers, 20 scenarios, dataset01, 8 workers
  • /benchmark AutoroutingPipelineSolver4 20 --profile-solvers -> one solver, 20 scenarios, with profile solver comparison tables
  • /benchmark --pipeline 4 -> same as ./benchmark.sh --pipeline 4

Use /update-snapshots (or /us) to run BUN_UPDATE_SNAPSHOTS=1 bun test --timeout 120_000 on the PR branch and auto-commit snapshot updates.
Use /usf to read recent failed test files, run BUN_UPDATE_SNAPSHOTS=1 bun test --timeout 120_000 <files>, auto-commit snapshot updates, then verify with bun test <files>.

Any PR whose title contains [BENCHMARK TEST] will automatically run the benchmark workflow on PR updates.

@0hmX 0hmX changed the title 0hmx/new overrides option feat: add overrides option for custom rectdiff May 4, 2026
@0hmX 0hmX changed the title feat: add overrides option for custom rectdiff feat: add overrides option for custom rectdiff ONLY AutoroutingPipelineSolver4_TinyHypergraph May 4, 2026
@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented May 4, 2026

Idk if i like this bc it breaks the common pattern BUT you can still use the changes by clicking on the build workflow and using the custom tar gz temporarily?

@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented May 4, 2026

Its not a bad idea but i want to think about how this could be a bit more ergonomic

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants