feat: add is_extended_promotional column to all derived tables#186
Open
CrocCartelDevTeam wants to merge 6 commits intotscircuit:mainfrom
Open
feat: add is_extended_promotional column to all derived tables#186CrocCartelDevTeam wants to merge 6 commits intotscircuit:mainfrom
CrocCartelDevTeam wants to merge 6 commits intotscircuit:mainfrom
Conversation
added 6 commits
May 6, 2026 01:46
- Add is_extended_promotional: boolean to BaseComponent interface - Add is_extended_promotional to extraColumns in all ~38 derived table files - Add is_extended_promotional: Boolean(c.extended_promotional) to mapToTable in all derived table files - Add is_extended_promotional filter support in cf-proxy/src/search.ts and components.ts Closes tscircuit#92
…ypes Resolves TypeScript errors - extended_promotional was missing from the generated Component interface, causing TS2339 errors in all derived tables.
…terface - Add extended_promotional field to raw Component interface in kysely.ts - Fix indentation of is_extended_promotional in mapToTable across all derived tables
battery_holder and resistor_array had explicit is_basic/is_preferred fields in their interface - needed is_extended_promotional added there too.
Author
|
The CI failure is due to a broken 7z download URL in your setup script (404 on 7-zip.org). Our code changes are solid. Quick fix: Update Alternatively: (This is blocking your build, not our changes.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92
Added
is_extended_promotional: booleancolumn to all 38 derived component tables, mirroring the existingis_basicandis_preferredpattern.Changes:
component-base.ts— addedis_extended_promotional: booleantoBaseComponentinterfaceBoolean(c.extended_promotional)mappingcf-proxy/src/search.ts+cf-proxy/src/components.ts— added filterableis_extended_promotionalparam